Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4124)

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Issue 2450623002: [MD Bookmarks] Add skeleton for Material Design Bookmarks (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
index d7404f2f904d8275416775bb1e69664accc4cf11..634bda4798d68f2c955f4f83d41955c7513afc24 100644
--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
@@ -118,6 +118,7 @@
#include "chrome/browser/signin/easy_unlock_service_factory.h"
#include "chrome/browser/ui/webui/devtools_ui.h"
#include "chrome/browser/ui/webui/inspect_ui.h"
+#include "chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.h"
#include "chrome/browser/ui/webui/md_downloads/md_downloads_ui.h"
#include "chrome/browser/ui/webui/md_feedback/md_feedback_ui.h"
#include "chrome/browser/ui/webui/md_history_ui.h"
@@ -424,8 +425,10 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,
#endif // !defined(OS_CHROMEOS)
// Bookmarks are part of NTP on Android.
- if (url.host() == chrome::kChromeUIBookmarksHost)
- return &NewWebUI<BookmarksUI>;
+ if (url.host() == chrome::kChromeUIBookmarksHost) {
+ return MdBookmarksUI::IsEnabled() ? &NewWebUI<MdBookmarksUI>
+ : &NewWebUI<BookmarksUI>;
+ }
// Downloads list on Android uses the built-in download manager.
if (url.host() == chrome::kChromeUIDownloadsHost)
return &NewWebUI<MdDownloadsUI>;
@@ -790,8 +793,10 @@ base::RefCountedMemory* ChromeWebUIControllerFactory::GetFaviconResourceBytes(
#if !defined(OS_ANDROID) // Bookmarks are part of NTP on Android.
// The bookmark manager is a chrome extension, so we have to check for it
// before we check for extension scheme.
- if (page_url.host() == extension_misc::kBookmarkManagerId)
+ if (page_url.host() == extension_misc::kBookmarkManagerId ||
+ page_url.host() == chrome::kChromeUIBookmarksHost) {
return BookmarksUI::GetFaviconResourceBytes(scale_factor);
+ }
// The extension scheme is handled in GetFaviconForURL.
if (page_url.SchemeIs(extensions::kExtensionScheme)) {

Powered by Google App Engine
This is Rietveld 408576698