Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3817)

Unified Diff: chrome/browser/extensions/component_loader.cc

Issue 2450623002: [MD Bookmarks] Add skeleton for Material Design Bookmarks (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/component_loader.cc
diff --git a/chrome/browser/extensions/component_loader.cc b/chrome/browser/extensions/component_loader.cc
index 7566a1fa3aca08b5ae6b0037fb71229602a2b088..6c7196a4636eef297a9df0fedca517807eaab952 100644
--- a/chrome/browser/extensions/component_loader.cc
+++ b/chrome/browser/extensions/component_loader.cc
@@ -21,7 +21,9 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/search/hotword_service.h"
#include "chrome/browser/search/hotword_service_factory.h"
+#include "chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.h"
#include "chrome/common/channel_info.h"
+#include "chrome/common/chrome_features.h"
benwells 2016/11/01 03:46:36 Nit: I don't think this include is needed
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension_constants.h"
@@ -471,17 +473,21 @@ void ComponentLoader::AddDefaultComponentExtensions(
if (!skip_session_components) {
const base::CommandLine* command_line =
base::CommandLine::ForCurrentProcess();
- if (!command_line->HasSwitch(chromeos::switches::kGuestSession))
+ if (!command_line->HasSwitch(chromeos::switches::kGuestSession) &&
+ !MdBookmarksUI::IsEnabled()) {
Add(IDR_BOOKMARKS_MANIFEST,
base::FilePath(FILE_PATH_LITERAL("bookmark_manager")));
+ }
Add(IDR_CROSH_BUILTIN_MANIFEST, base::FilePath(FILE_PATH_LITERAL(
"/usr/share/chromeos-assets/crosh_builtin")));
}
#else // defined(OS_CHROMEOS)
DCHECK(!skip_session_components);
- Add(IDR_BOOKMARKS_MANIFEST,
- base::FilePath(FILE_PATH_LITERAL("bookmark_manager")));
+ if (!MdBookmarksUI::IsEnabled()) {
+ Add(IDR_BOOKMARKS_MANIFEST,
+ base::FilePath(FILE_PATH_LITERAL("bookmark_manager")));
+ }
#if defined(ENABLE_PRINTING)
// Cloud Print component app. Not required on Chrome OS.
Add(IDR_CLOUDPRINT_MANIFEST,

Powered by Google App Engine
This is Rietveld 408576698