Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2450583002: Return "auto" for computed z-index on non-stacking-context element (Closed)

Created:
4 years, 1 month ago by alancutter (OOO until 2018)
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Return "auto" for computed z-index on non-stacking-context element Following https://codereview.chromium.org/2047283002 we were returning "0" for getComputedStyle(element).zIndex for elements that were not stacking contexts. Previously we would return "auto". Both behaviours are incorrect. This patch reverts the change in getComputedStyle() behaviour back to "auto". BUG=656681 Review-Url: https://chromiumcodereview.appspot.com/2439663002 Cr-Commit-Position: refs/heads/master@{#426690} (cherry picked from commit 664d4716b91e01c779a77702e9f219c2744724e0) Committed: https://chromium.googlesource.com/chromium/src/+/f22b7f69fd74027b685047b3f06dab55a0b69a04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-zIndex-non-auto-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
alancutter (OOO until 2018)
4 years, 1 month ago (2016-10-25 00:04:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f22b7f69fd74027b685047b3f06dab55a0b69a04.

Powered by Google App Engine
This is Rietveld 408576698