Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2450583002: Return "auto" for computed z-index on non-stacking-context element (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-zIndex-non-auto-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Zack Rusin <zack@kde.org> 2 * Copyright (C) 2004 Zack Rusin <zack@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc.
4 * All rights reserved. 4 * All rights reserved.
5 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 5 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
6 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 6 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
7 * Copyright (C) 2011 Sencha, Inc. All rights reserved. 7 * Copyright (C) 2011 Sencha, Inc. All rights reserved.
8 * Copyright (C) 2015 Google Inc. All rights reserved. 8 * Copyright (C) 2015 Google Inc. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 2801 matching lines...) Expand 10 before | Expand all | Expand 10 after
2812 case CSSPropertyWebkitFontSmoothing: 2812 case CSSPropertyWebkitFontSmoothing:
2813 return CSSIdentifierValue::create( 2813 return CSSIdentifierValue::create(
2814 style.getFontDescription().fontSmoothing()); 2814 style.getFontDescription().fontSmoothing());
2815 case CSSPropertyFontVariantLigatures: 2815 case CSSPropertyFontVariantLigatures:
2816 return valueForFontVariantLigatures(style); 2816 return valueForFontVariantLigatures(style);
2817 case CSSPropertyFontVariantCaps: 2817 case CSSPropertyFontVariantCaps:
2818 return valueForFontVariantCaps(style); 2818 return valueForFontVariantCaps(style);
2819 case CSSPropertyFontVariantNumeric: 2819 case CSSPropertyFontVariantNumeric:
2820 return valueForFontVariantNumeric(style); 2820 return valueForFontVariantNumeric(style);
2821 case CSSPropertyZIndex: 2821 case CSSPropertyZIndex:
2822 if (style.hasAutoZIndex()) 2822 if (style.hasAutoZIndex() || !style.isStackingContext())
2823 return CSSIdentifierValue::create(CSSValueAuto); 2823 return CSSIdentifierValue::create(CSSValueAuto);
2824 return CSSPrimitiveValue::create(style.zIndex(), 2824 return CSSPrimitiveValue::create(style.zIndex(),
2825 CSSPrimitiveValue::UnitType::Integer); 2825 CSSPrimitiveValue::UnitType::Integer);
2826 case CSSPropertyZoom: 2826 case CSSPropertyZoom:
2827 return CSSPrimitiveValue::create(style.zoom(), 2827 return CSSPrimitiveValue::create(style.zoom(),
2828 CSSPrimitiveValue::UnitType::Number); 2828 CSSPrimitiveValue::UnitType::Number);
2829 case CSSPropertyBoxSizing: 2829 case CSSPropertyBoxSizing:
2830 if (style.boxSizing() == BoxSizingContentBox) 2830 if (style.boxSizing() == BoxSizingContentBox)
2831 return CSSIdentifierValue::create(CSSValueContentBox); 2831 return CSSIdentifierValue::create(CSSValueContentBox);
2832 return CSSIdentifierValue::create(CSSValueBorderBox); 2832 return CSSIdentifierValue::create(CSSValueBorderBox);
(...skipping 766 matching lines...) Expand 10 before | Expand all | Expand 10 after
3599 case CSSPropertyAll: 3599 case CSSPropertyAll:
3600 return nullptr; 3600 return nullptr;
3601 default: 3601 default:
3602 break; 3602 break;
3603 } 3603 }
3604 ASSERT_NOT_REACHED(); 3604 ASSERT_NOT_REACHED();
3605 return nullptr; 3605 return nullptr;
3606 } 3606 }
3607 3607
3608 } // namespace blink 3608 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-zIndex-non-auto-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698