Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2450423002: [MD settings] cookie and site data from dialog to subpage (Closed)

Created:
4 years, 1 month ago by dschuyler
Modified:
4 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] cookie and site data from dialog to subpage This CL moves the cookie data details from a dialog into a settings subpage. BUG=654943 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0f58402502d291872de78265747751f4728b9e36 Cr-Commit-Position: refs/heads/master@{#429392}

Patch Set 1 #

Patch Set 2 : change upstream branch #

Patch Set 3 : merge #

Patch Set 4 : merge #

Total comments: 19

Patch Set 5 : review changes #

Total comments: 2

Patch Set 6 : changed remove all #

Patch Set 7 : added closure type #

Patch Set 8 : improved closure type reference #

Total comments: 2

Patch Set 9 : review nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -296 lines) Patch
M chrome/app/settings_strings.grdp View 1 2 3 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/privacy_page/compiled_resources2.gyp View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 1 2 3 4 5 2 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.js View 1 2 3 4 5 6 7 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/route.js View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/compiled_resources2.gyp View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/cookie_tree_behavior.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/cookie_tree_node.js View 1 2 3 4 2 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_data.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_data.js View 1 2 1 chunk +2 lines, -10 lines 0 comments Download
D chrome/browser/resources/settings/site_settings/site_data_details_dialog.html View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/resources/settings/site_settings/site_data_details_dialog.js View 1 2 3 1 chunk +0 lines, -203 lines 0 comments Download
A chrome/browser/resources/settings/site_settings/site_data_details_subpage.html View 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/resources/settings/site_settings/site_data_details_subpage.js View 1 2 3 4 5 6 7 8 1 chunk +135 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 48 (37 generated)
dschuyler
4 years, 1 month ago (2016-10-27 21:17:00 UTC) #13
Dan Beam
sorry i didn't get to this today, will look over the weekend or on monday
4 years, 1 month ago (2016-10-29 01:19:03 UTC) #16
Dan Beam
lookin' pretty good! https://codereview.chromium.org/2450423002/diff/60001/chrome/browser/resources/settings/route.js File chrome/browser/resources/settings/route.js (right): https://codereview.chromium.org/2450423002/diff/60001/chrome/browser/resources/settings/route.js#newcode155 chrome/browser/resources/settings/route.js:155: r.SITE_SETTINGS_COOKIES.createChild('/siteSettings/siteDataDetails'); this is kind of an ...
4 years, 1 month ago (2016-11-01 06:33:28 UTC) #19
dschuyler
https://codereview.chromium.org/2450423002/diff/60001/chrome/browser/resources/settings/route.js File chrome/browser/resources/settings/route.js (right): https://codereview.chromium.org/2450423002/diff/60001/chrome/browser/resources/settings/route.js#newcode155 chrome/browser/resources/settings/route.js:155: r.SITE_SETTINGS_COOKIES.createChild('/siteSettings/siteDataDetails'); On 2016/11/01 06:33:27, Dan Beam wrote: > this ...
4 years, 1 month ago (2016-11-01 18:55:35 UTC) #22
Dan Beam
https://codereview.chromium.org/2450423002/diff/60001/chrome/browser/resources/settings/site_settings/cookie_tree_node.js File chrome/browser/resources/settings/site_settings/cookie_tree_node.js (left): https://codereview.chromium.org/2450423002/diff/60001/chrome/browser/resources/settings/site_settings/cookie_tree_node.js#oldcode187 chrome/browser/resources/settings/site_settings/cookie_tree_node.js:187: On 2016/11/01 18:55:34, dschuyler wrote: > On 2016/11/01 06:33:27, ...
4 years, 1 month ago (2016-11-01 19:10:15 UTC) #23
dschuyler
https://codereview.chromium.org/2450423002/diff/80001/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js File chrome/browser/resources/settings/site_settings/site_data_details_subpage.js (right): https://codereview.chromium.org/2450423002/diff/80001/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js#newcode44 chrome/browser/resources/settings/site_settings/site_data_details_subpage.js:44: 'tap', this.onRemoveAll_.bind(this)); On 2016/11/01 19:10:15, Dan Beam wrote: > ...
4 years, 1 month ago (2016-11-01 19:46:55 UTC) #26
Dan Beam
lgtm https://codereview.chromium.org/2450423002/diff/130001/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js File chrome/browser/resources/settings/site_settings/site_data_details_subpage.js (right): https://codereview.chromium.org/2450423002/diff/130001/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js#newcode40 chrome/browser/resources/settings/site_settings/site_data_details_subpage.js:40: this.onCookiesLoaded_.bind(this)); nit: listeners: {'cookie-tree-changed': 'onCookiesLoaded_'},
4 years, 1 month ago (2016-11-02 06:13:11 UTC) #37
dschuyler
https://codereview.chromium.org/2450423002/diff/130001/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js File chrome/browser/resources/settings/site_settings/site_data_details_subpage.js (right): https://codereview.chromium.org/2450423002/diff/130001/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js#newcode40 chrome/browser/resources/settings/site_settings/site_data_details_subpage.js:40: this.onCookiesLoaded_.bind(this)); On 2016/11/02 06:13:11, Dan Beam wrote: > nit: ...
4 years, 1 month ago (2016-11-02 18:24:49 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450423002/150001
4 years, 1 month ago (2016-11-02 20:36:11 UTC) #45
commit-bot: I haz the power
Committed patchset #9 (id:150001)
4 years, 1 month ago (2016-11-02 20:45:12 UTC) #46
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 20:48:31 UTC) #48
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/0f58402502d291872de78265747751f4728b9e36
Cr-Commit-Position: refs/heads/master@{#429392}

Powered by Google App Engine
This is Rietveld 408576698