Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2935)

Unified Diff: chrome/browser/resources/settings/site_settings/site_data.js

Issue 2450423002: [MD settings] cookie and site data from dialog to subpage (Closed)
Patch Set: review nit Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/site_data.js
diff --git a/chrome/browser/resources/settings/site_settings/site_data.js b/chrome/browser/resources/settings/site_settings/site_data.js
index 6b1934c298d2c425ae18aff7a8740b383b2e3a78..e5e786790c6218dab5363b68f5168e48afd0d6b7 100644
--- a/chrome/browser/resources/settings/site_settings/site_data.js
+++ b/chrome/browser/resources/settings/site_settings/site_data.js
@@ -125,15 +125,7 @@ Polymer({
* @private
*/
onSiteTap_: function(event) {
- var dialog = document.createElement('site-data-details-dialog');
- dialog.category = this.category;
- this.shadowRoot.appendChild(dialog);
-
- var node = this.rootCookieNode.fetchNodeById(event.model.item.id, false);
- dialog.open(node);
-
- dialog.addEventListener('close', function(event) {
- dialog.remove();
- });
+ settings.navigateTo(settings.Route.SITE_SETTINGS_DATA_DETAILS,
+ new URLSearchParams('site=' + event.model.item.site));
},
});

Powered by Google App Engine
This is Rietveld 408576698