Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2450353004: Move ViewHostMsg_CreateWidget to mojom (Closed)

Created:
4 years, 1 month ago by Jay Civelli
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Converts the ViewHostMsg_CreateWidget message to mojom. BUG=612500 Committed: https://crrev.com/ae1560a11b938a67fe7ef11f23268617e0915d5e Cr-Commit-Position: refs/heads/master@{#429139}

Patch Set 1 #

Patch Set 2 : More work. #

Patch Set 3 : Move ViewHostMsg_CreateWidget to mojom #

Patch Set 4 : Move ViewHostMsg_CreateWidget to mojom #

Total comments: 4

Patch Set 5 : Addressed jam's comments + sync #

Total comments: 2

Patch Set 6 : Addressed @tsepez's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -38 lines) Patch
M content/browser/renderer_host/render_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 2 3 4 3 chunks +9 lines, -7 lines 0 comments Download
M content/common/native_types.mojom View 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/native_types.typemap View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M content/common/render_message_filter.mojom View 2 chunks +6 lines, -0 lines 0 comments Download
M content/common/swapped_out_messages.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/view_messages.h View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
M content/public/test/mock_render_thread.h View 1 1 chunk +4 lines, -5 lines 0 comments Download
M content/public/test/mock_render_thread.cc View 1 2 3 4 4 chunks +15 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_widget.h View 1 3 chunks +7 lines, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 5 chunks +16 lines, -7 lines 0 comments Download
M content/renderer/render_widget_fullscreen.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_widget_fullscreen.cc View 1 2 chunks +9 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 37 (22 generated)
Jay Civelli
4 years, 1 month ago (2016-10-27 22:47:53 UTC) #6
Ken Rockot(use gerrit already)
lgtm
4 years, 1 month ago (2016-10-31 19:44:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450353004/40001
4 years, 1 month ago (2016-10-31 20:06:49 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/293429)
4 years, 1 month ago (2016-10-31 20:16:14 UTC) #17
Jay Civelli
Adding @jam for content/ OWNER review. Thanks!
4 years, 1 month ago (2016-10-31 20:26:24 UTC) #19
jam
lgtm https://codereview.chromium.org/2450353004/diff/60001/content/browser/renderer_host/render_message_filter.cc File content/browser/renderer_host/render_message_filter.cc (right): https://codereview.chromium.org/2450353004/diff/60001/content/browser/renderer_host/render_message_filter.cc#newcode303 content/browser/renderer_host/render_message_filter.cc:303: { nit: bracket on previous line per style ...
4 years, 1 month ago (2016-11-01 17:11:45 UTC) #20
Jay Civelli
https://codereview.chromium.org/2450353004/diff/60001/content/browser/renderer_host/render_message_filter.cc File content/browser/renderer_host/render_message_filter.cc (right): https://codereview.chromium.org/2450353004/diff/60001/content/browser/renderer_host/render_message_filter.cc#newcode303 content/browser/renderer_host/render_message_filter.cc:303: { On 2016/11/01 17:11:45, jam wrote: > nit: bracket ...
4 years, 1 month ago (2016-11-01 20:47:29 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450353004/80001
4 years, 1 month ago (2016-11-01 20:48:07 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/294375)
4 years, 1 month ago (2016-11-01 20:56:41 UTC) #26
Jay Civelli
Adding @tsepez for SECURITY_OWNER review of content/common/*_messages.h and content/common/*.mojom Thanks.
4 years, 1 month ago (2016-11-01 21:03:03 UTC) #28
Tom Sepez
lgtm https://codereview.chromium.org/2450353004/diff/80001/content/common/native_types.typemap File content/common/native_types.typemap (right): https://codereview.chromium.org/2450353004/diff/80001/content/common/native_types.typemap#newcode46 content/common/native_types.typemap:46: "content.mojom.WebPopupType=blink::WebPopupType", nit: alphabetize.
4 years, 1 month ago (2016-11-01 21:06:13 UTC) #29
Jay Civelli
https://codereview.chromium.org/2450353004/diff/80001/content/common/native_types.typemap File content/common/native_types.typemap (right): https://codereview.chromium.org/2450353004/diff/80001/content/common/native_types.typemap#newcode46 content/common/native_types.typemap:46: "content.mojom.WebPopupType=blink::WebPopupType", On 2016/11/01 21:06:13, Tom Sepez wrote: > nit: ...
4 years, 1 month ago (2016-11-01 21:08:41 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450353004/100001
4 years, 1 month ago (2016-11-01 21:09:31 UTC) #33
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 1 month ago (2016-11-01 22:40:51 UTC) #35
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 22:42:36 UTC) #37
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/ae1560a11b938a67fe7ef11f23268617e0915d5e
Cr-Commit-Position: refs/heads/master@{#429139}

Powered by Google App Engine
This is Rietveld 408576698