Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Unified Diff: content/browser/renderer_host/render_message_filter.cc

Issue 2450353004: Move ViewHostMsg_CreateWidget to mojom (Closed)
Patch Set: Addressed @tsepez's comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_message_filter.h ('k') | content/common/native_types.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_message_filter.cc
diff --git a/content/browser/renderer_host/render_message_filter.cc b/content/browser/renderer_host/render_message_filter.cc
index 95d3193c5bea6cb7bbfa5a1b2299f176d6788f88..897ae25c7d0f343338970c5455cdb85cb075f50d 100644
--- a/content/browser/renderer_host/render_message_filter.cc
+++ b/content/browser/renderer_host/render_message_filter.cc
@@ -169,7 +169,6 @@ RenderMessageFilter::~RenderMessageFilter() {
bool RenderMessageFilter::OnMessageReceived(const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(RenderMessageFilter, message)
- IPC_MESSAGE_HANDLER(ViewHostMsg_CreateWidget, OnCreateWidget)
IPC_MESSAGE_HANDLER(ViewHostMsg_CreateFullscreenWidget,
OnCreateFullscreenWidget)
#if defined(OS_MACOSX)
@@ -242,12 +241,6 @@ void RenderMessageFilter::OverrideThreadForMessage(const IPC::Message& message,
*thread = BrowserThread::UI;
}
-void RenderMessageFilter::OnCreateWidget(int opener_id,
- blink::WebPopupType popup_type,
- int* route_id) {
- render_widget_helper_->CreateNewWidget(opener_id, popup_type, route_id);
-}
-
void RenderMessageFilter::OnCreateFullscreenWidget(int opener_id,
int* route_id) {
render_widget_helper_->CreateNewFullscreenWidget(opener_id, route_id);
@@ -303,6 +296,15 @@ void RenderMessageFilter::CreateNewWindow(
callback.Run(std::move(reply));
}
+void RenderMessageFilter::CreateNewWidget(
+ int32_t opener_id,
+ blink::WebPopupType popup_type,
+ const CreateNewWidgetCallback& callback) {
+ int route_id = MSG_ROUTING_NONE;
+ render_widget_helper_->CreateNewWidget(opener_id, popup_type, &route_id);
+ callback.Run(route_id);
+}
+
#if defined(OS_MACOSX)
void RenderMessageFilter::OnLoadFont(const FontDescriptor& font,
« no previous file with comments | « content/browser/renderer_host/render_message_filter.h ('k') | content/common/native_types.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698