Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: chrome/browser/cocoa/bookmark_menu_bridge.mm

Issue 245035: Bookmark menus not updated when their name is edited in the bookmark bar.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/bookmark_menu_bridge.h ('k') | chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/bookmark_menu_bridge.mm
===================================================================
--- chrome/browser/cocoa/bookmark_menu_bridge.mm (revision 27404)
+++ chrome/browser/cocoa/bookmark_menu_bridge.mm (working copy)
@@ -94,14 +94,14 @@
const BookmarkNode* node) {
NSMenuItem* item = MenuItemForNode(node);
if (item)
- ConfigureMenuItem(node, item);
+ ConfigureMenuItem(node, item, true);
}
void BookmarkMenuBridge::BookmarkNodeFavIconLoaded(BookmarkModel* model,
const BookmarkNode* node) {
NSMenuItem* item = MenuItemForNode(node);
if (item)
- ConfigureMenuItem(node, item);
+ ConfigureMenuItem(node, item, false);
}
void BookmarkMenuBridge::BookmarkNodeChildrenReordered(
@@ -180,13 +180,18 @@
[menu setSubmenu:submenu forItem:item];
AddNodeToMenu(child, submenu); // recursive call
} else {
- ConfigureMenuItem(child, item);
+ ConfigureMenuItem(child, item, false);
}
}
}
void BookmarkMenuBridge::ConfigureMenuItem(const BookmarkNode* node,
- NSMenuItem* item) {
+ NSMenuItem* item,
+ bool set_title) {
+ if (set_title) {
+ NSString* title = [BookmarkMenuCocoaController menuTitleForNode:node];
+ [item setTitle:title];
+ }
[item setTarget:controller_];
[item setAction:@selector(openBookmarkMenuItem:)];
[item setTag:node->id()];
« no previous file with comments | « chrome/browser/cocoa/bookmark_menu_bridge.h ('k') | chrome/browser/cocoa/bookmark_menu_bridge_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698