Bookmark menus not updated when their name is edited in the bookmark bar....

chrome/browser/cocoa/bookmark_menu_bridge.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <AppKit/AppKit.h>
 
 #include "app/l10n_util.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/app/chrome_dll_resource.h"  // IDC_BOOKMARK_MENU
 #import "chrome/browser/app_controller_mac.h"
@@ skipping 76 matching lines @@
                                              int old_index,
                                              const BookmarkNode* node) {
   // TODO(jrg): this is brute force; perhaps we should be nicer.
   Loaded(model);
 }
 
 void BookmarkMenuBridge::BookmarkNodeChanged(BookmarkModel* model,
                                              const BookmarkNode* node) {
   NSMenuItem* item = MenuItemForNode(node);
   if (item)
-    ConfigureMenuItem(node, item);
+    ConfigureMenuItem(node, item, true);
 }
 
 void BookmarkMenuBridge::BookmarkNodeFavIconLoaded(BookmarkModel* model,
                                                    const BookmarkNode* node) {
   NSMenuItem* item = MenuItemForNode(node);
   if (item)
-    ConfigureMenuItem(node, item);
+    ConfigureMenuItem(node, item, false);
 }
 
 void BookmarkMenuBridge::BookmarkNodeChildrenReordered(
     BookmarkModel* model, const BookmarkNode* node) {
   // TODO(jrg): this is brute force; perhaps we should be nicer.
   Loaded(model);
 }
 
 // Watch for changes.
 void BookmarkMenuBridge::ObserveBookmarkModel() {
@@ skipping 58 matching lines @@
     NSMenuItem* item = [[[NSMenuItem alloc] initWithTitle:title
                                                    action:nil
                                             keyEquivalent:@""] autorelease];
     [menu addItem:item];
     bookmark_nodes_[child] = item;
     if (child->is_folder()) {
       NSMenu* submenu = [[[NSMenu alloc] initWithTitle:title] autorelease];
       [menu setSubmenu:submenu forItem:item];
       AddNodeToMenu(child, submenu);  // recursive call
     } else {
-      ConfigureMenuItem(child, item);
+      ConfigureMenuItem(child, item, false);
     }
   }
 }
 
 void BookmarkMenuBridge::ConfigureMenuItem(const BookmarkNode* node,
-                                           NSMenuItem* item) {
+                                           NSMenuItem* item,
+                                           bool set_title) {
+  if (set_title) {
+    NSString* title = [BookmarkMenuCocoaController menuTitleForNode:node];
+    [item setTitle:title];
+  }
   [item setTarget:controller_];
   [item setAction:@selector(openBookmarkMenuItem:)];
   [item setTag:node->id()];
   // Add a tooltip
   std::string url_string = node->GetURL().possibly_invalid_spec();
   NSString* tooltip = [NSString stringWithFormat:@"%@\n%s",
                                 base::SysWideToNSString(node->GetTitle()),
                                 url_string.c_str()];
   [item setToolTip:tooltip];
 
@@ skipping 14 matching lines @@
 
 NSMenuItem* BookmarkMenuBridge::MenuItemForNode(const BookmarkNode* node) {
   if (!node)
     return nil;
   std::map<const BookmarkNode*, NSMenuItem*>::iterator it =
       bookmark_nodes_.find(node);
   if (it == bookmark_nodes_.end())
     return nil;
   return it->second;
 }