Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1359)

Unified Diff: third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp

Issue 2450293003: Third-party iframe logging: Separate AboveAndLeft from Above (Closed)
Patch Set: better histogram description Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp b/third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp
index 911ad3bc4745d7fe61d31ef5d93e756f5234c970..aba9e636a92dcd006f6b3b6a58d4d718a849580f 100644
--- a/third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp
+++ b/third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp
@@ -13,7 +13,7 @@
namespace blink {
static const char* kHistogramName =
- "Navigation.DeferredDocumentLoading.StatesV2";
+ "Navigation.DeferredDocumentLoading.StatesV3";
class DeferredLoadingTest : public SimTest {
protected:
@@ -108,9 +108,8 @@ TEST_F(DeferredLoadingTest, AboveAndLeft) {
compositeFrame();
- // Don't log WouldLoadAbove AND WouldLoadLeft.
histogramTester.expectBucketCount(kHistogramName, Created, 1);
- histogramTester.expectBucketCount(kHistogramName, WouldLoadAbove, 1);
+ histogramTester.expectBucketCount(kHistogramName, WouldLoadAboveAndLeft, 1);
histogramTester.expectTotalCount(kHistogramName, 2);
}

Powered by Google App Engine
This is Rietveld 408576698