third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 2450293003: Third-party iframe logging: Separate AboveAndLeft from Above

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2450293003: Third-party iframe logging: Separate AboveAndLeft from Above (Closed)

Patch Set: better histogram description Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index a3537839378bfed23940dbbef65496c9484447bf..8a0207c5d9f2d57bce6dae6060399a0759a091a6 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -4347,6 +4347,8 @@ void FrameView::updateViewportIntersectionIfNeeded() {

if (parentLoaded) {

if (frameRect().isEmpty())

frame().document()->maybeRecordLoadReason(WouldLoadZeroByZero);

+ else if (frameRect().maxY() < 0 && frameRect().maxX() < 0)

+ frame().document()->maybeRecordLoadReason(WouldLoadAboveAndLeft);

else if (frameRect().maxY() < 0)

frame().document()->maybeRecordLoadReason(WouldLoadAbove);

else if (frameRect().maxX() < 0)