Third-party iframe logging: Separate AboveAndLeft from Above

Third-party iframe logging: Separate out AboveAndLeft from Above

Early data shows that iframes above the page, which includes iframes
that are simultaneously above AND left of the page, are 25x more common
than iframes only to the left of the page. It's possible that
AboveAndLeft are most common, which could explain the discrepancy.

BUG=635105
Committed: https://crrev.com/e10fbfce772e735f8b5fbedb94a67bff8e8f8e91
Cr-Commit-Position: refs/heads/master@{#428278}

[dgrogan, 2016-10-26 18:02:17]

Description was changed from

==========
Third-party iframe logging: Separate AboveAndLeft from Above

Early data shows that iframes above the page, which includes iframes
above AND left, are 25x more common than iframes to the left of the
page. That's unexpected. It's possible that above and left are the most
common, which could explain the discrepancy.

BUG=635105
==========

to

==========
Third-party iframe logging: Separate out AboveAndLeft from Above

Early data shows that iframes above the page, which includes iframes
above AND left, are 25x more common than iframes to the left of the
page. That's unexpected. It's possible that above and left are the most
common, which could explain the discrepancy.

BUG=635105
==========

[dgrogan, 2016-10-26 18:04:16]

Description was changed from

==========
Third-party iframe logging: Separate out AboveAndLeft from Above

Early data shows that iframes above the page, which includes iframes
above AND left, are 25x more common than iframes to the left of the
page. That's unexpected. It's possible that above and left are the most
common, which could explain the discrepancy.

BUG=635105
==========

to

==========
Third-party iframe logging: Separate out AboveAndLeft from Above

Early data shows that iframes above the page, which includes iframes
that are simultaneously above AND left, are 25x more common than iframes
to the left of the page. That's unexpected. It's possible that
AboveAndLeft are most common, which could explain the discrepancy.

BUG=635105
==========

[dgrogan, 2016-10-26 18:05:49]

Description was changed from

==========
Third-party iframe logging: Separate out AboveAndLeft from Above

Early data shows that iframes above the page, which includes iframes
that are simultaneously above AND left, are 25x more common than iframes
to the left of the page. That's unexpected. It's possible that
AboveAndLeft are most common, which could explain the discrepancy.

BUG=635105
==========

to

==========
Third-party iframe logging: Separate out AboveAndLeft from Above

Early data shows that iframes above the page, which includes iframes
that are simultaneously above AND left of the page, are 25x more common
than iframes only to the left of the page. It's possible that
AboveAndLeft are most common, which could explain the discrepancy.

BUG=635105
==========

[dgrogan, 2016-10-26 18:08:20]

dgrogan@chromium.org changed reviewers:
+ dcheng@chromium.org

[dgrogan, 2016-10-26 18:08:20]

Hi Daniel, sorry to throw another logging review your way. No good deed goes
unpunished :\

[dcheng, 2016-10-27 03:05:41]

lgtm

[dgrogan, 2016-10-27 16:43:04]

dgrogan@chromium.org changed reviewers:
+ isherman@chromium.org

[dgrogan, 2016-10-27 16:43:04]

isherman, could you review this? I'm changing the histogram name again because
this CL changes the meaning of the "Above" bucket

[Ilya Sherman, 2016-10-27 20:51:22]

histograms.xml LGTM % a comment:

https://codereview.chromium.org/2450293003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2450293003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:27465: +    loading as long as possible.
Difference from V2: frames positioned both
Please mark V2 as <obsolete>

[dgrogan, 2016-10-27 20:57:02]

Thanks for the reviews!

https://codereview.chromium.org/2450293003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2450293003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:27465: +    loading as long as possible.
Difference from V2: frames positioned both
On 2016/10/27 20:51:21, Ilya Sherman wrote:
> Please mark V2 as <obsolete>

Done.

[dgrogan, 2016-10-27 21:00:51]

The CQ bit was checked by dgrogan@chromium.org

[dgrogan, 2016-10-27 21:00:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2450293003/#ps40001
(title: "mark V2 histograms obsolete")

[commit-bot: I haz the power, 2016-10-27 21:02:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 22:28:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 22:28:39]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[dgrogan, 2016-10-27 22:33:19]

The CQ bit was checked by dgrogan@chromium.org

[commit-bot: I haz the power, 2016-10-27 22:34:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 23:54:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 23:54:47]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dgrogan, 2016-10-28 02:40:55]

The CQ bit was checked by dgrogan@chromium.org

[commit-bot: I haz the power, 2016-10-28 02:41:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 04:06:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-28 04:09:32]

Description was changed from

==========
Third-party iframe logging: Separate out AboveAndLeft from Above

Early data shows that iframes above the page, which includes iframes
that are simultaneously above AND left of the page, are 25x more common
than iframes only to the left of the page. It's possible that
AboveAndLeft are most common, which could explain the discrepancy.

BUG=635105
==========

to

==========
Third-party iframe logging: Separate out AboveAndLeft from Above

Early data shows that iframes above the page, which includes iframes
that are simultaneously above AND left of the page, are 25x more common
than iframes only to the left of the page. It's possible that
AboveAndLeft are most common, which could explain the discrepancy.

BUG=635105

Committed: https://crrev.com/e10fbfce772e735f8b5fbedb94a67bff8e8f8e91
Cr-Commit-Position: refs/heads/master@{#428278}
==========

[commit-bot: I haz the power, 2016-10-28 04:09:33]

Patchset 3 (id:??) landed as
https://crrev.com/e10fbfce772e735f8b5fbedb94a67bff8e8f8e91
Cr-Commit-Position: refs/heads/master@{#428278}