Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 2450293003: Third-party iframe logging: Separate AboveAndLeft from Above (Closed)
Patch Set: mark V2 histograms obsolete Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All
7 * rights reserved. 7 * rights reserved.
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
9 * (http://www.torchmobile.com/) 9 * (http://www.torchmobile.com/)
10 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 10 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 // cross-origin documents log Created. Only those that would load log a reason. 240 // cross-origin documents log Created. Only those that would load log a reason.
241 // We can then see the % of cross-origin documents that never have to load. 241 // We can then see the % of cross-origin documents that never have to load.
242 // See https://crbug.com/635105. 242 // See https://crbug.com/635105.
243 // Logged to UMA, don't re-arrange entries without creating a new histogram. 243 // Logged to UMA, don't re-arrange entries without creating a new histogram.
244 enum WouldLoadReason { 244 enum WouldLoadReason {
245 Created, 245 Created,
246 // If outer and inner frames aren't in the same process we can't determine 246 // If outer and inner frames aren't in the same process we can't determine
247 // if the inner frame is visible, so just load it. 247 // if the inner frame is visible, so just load it.
248 // TODO(dgrogan): Revisit after https://crbug.com/650433 is fixed. 248 // TODO(dgrogan): Revisit after https://crbug.com/650433 is fixed.
249 WouldLoadOutOfProcess, 249 WouldLoadOutOfProcess,
250 // The next four indicate frames that are probably used for cross-origin 250 // The next five indicate frames that are probably used for cross-origin
251 // communication. 251 // communication.
252 WouldLoadDisplayNone, 252 WouldLoadDisplayNone,
253 WouldLoadZeroByZero, 253 WouldLoadZeroByZero,
254 WouldLoadAboveAndLeft,
254 WouldLoadAbove, 255 WouldLoadAbove,
255 WouldLoadLeft, 256 WouldLoadLeft,
256 // We have to load documents in visible frames. 257 // We have to load documents in visible frames.
257 WouldLoadVisible, 258 WouldLoadVisible,
258 259
259 WouldLoadReasonEnd 260 WouldLoadReasonEnd
260 }; 261 };
261 262
262 using DocumentClassFlags = unsigned char; 263 using DocumentClassFlags = unsigned char;
263 264
(...skipping 1460 matching lines...) Expand 10 before | Expand all | Expand 10 after
1724 DEFINE_TYPE_CASTS(TreeScope, Document, document, true, true); 1725 DEFINE_TYPE_CASTS(TreeScope, Document, document, true, true);
1725 1726
1726 } // namespace blink 1727 } // namespace blink
1727 1728
1728 #ifndef NDEBUG 1729 #ifndef NDEBUG
1729 // Outside the WebCore namespace for ease of invocation from gdb. 1730 // Outside the WebCore namespace for ease of invocation from gdb.
1730 CORE_EXPORT void showLiveDocumentInstances(); 1731 CORE_EXPORT void showLiveDocumentInstances();
1731 #endif 1732 #endif
1732 1733
1733 #endif // Document_h 1734 #endif // Document_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698