Utilize EditCommand::setEndingSelection() taking SelectionInDOMTree

third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp

Index: third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
index 2f347a9ef57456ed078d5b46e21f91ae98bad185..04076d33d86bc100d0134c2eb6cb2726d7ae4965 100644
--- a/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
@@ -126,12 +126,10 @@ void InsertLineBreakCommand::doApply(EditingState* editingState) {
       nodeToInsert = extraNode;
     }
 
-    document().updateStyleAndLayoutIgnorePendingStylesheets();
-    setEndingSelection(createVisibleSelection(
-        SelectionInDOMTree::Builder()
-            .collapse(Position::beforeNode(nodeToInsert))
-            .setIsDirectional(endingSelection().isDirectional())
-            .build()));
+    setEndingSelection(SelectionInDOMTree::Builder()
+                           .collapse(Position::beforeNode(nodeToInsert))
+                           .setIsDirectional(endingSelection().isDirectional())
+                           .build());
   } else if (pos.computeEditingOffset() <= caretMinOffset(pos.anchorNode())) {
     insertNodeAt(nodeToInsert, pos, editingState);
     if (editingState->isAborted())
@@ -147,11 +145,10 @@ void InsertLineBreakCommand::doApply(EditingState* editingState) {
       document().updateStyleAndLayoutIgnorePendingStylesheets();

[Xiaocheng, 2016/10/28 02:25:26]

This can also be removed.

[yosin_UTC9, 2016/10/28 06:06:49]

Done.

     }
 
-    setEndingSelection(createVisibleSelection(
-        SelectionInDOMTree::Builder()
-            .collapse(Position::inParentAfterNode(*nodeToInsert))
-            .setIsDirectional(endingSelection().isDirectional())
-            .build()));
+    setEndingSelection(SelectionInDOMTree::Builder()
+                           .collapse(Position::inParentAfterNode(*nodeToInsert))
+                           .setIsDirectional(endingSelection().isDirectional())
+                           .build());
     // If we're inserting after all of the rendered text in a text node, or into
     // a non-text node, a simple insertion is sufficient.
   } else if (!pos.anchorNode()->isTextNode() ||
@@ -160,12 +157,10 @@ void InsertLineBreakCommand::doApply(EditingState* editingState) {
     insertNodeAt(nodeToInsert, pos, editingState);
     if (editingState->isAborted())
       return;
-    document().updateStyleAndLayoutIgnorePendingStylesheets();
-    setEndingSelection(createVisibleSelection(
-        SelectionInDOMTree::Builder()
-            .collapse(Position::inParentAfterNode(*nodeToInsert))
-            .setIsDirectional(endingSelection().isDirectional())
-            .build()));
+    setEndingSelection(SelectionInDOMTree::Builder()
+                           .collapse(Position::inParentAfterNode(*nodeToInsert))
+                           .setIsDirectional(endingSelection().isDirectional())
+                           .build());
   } else if (pos.anchorNode()->isTextNode()) {
     // Split a text node
     Text* textNode = toText(pos.anchorNode());
@@ -198,12 +193,10 @@ void InsertLineBreakCommand::doApply(EditingState* editingState) {
       }
     }
 
-    document().updateStyleAndLayoutIgnorePendingStylesheets();
-    setEndingSelection(createVisibleSelection(
-        SelectionInDOMTree::Builder()
-            .collapse(endingPosition)
-            .setIsDirectional(endingSelection().isDirectional())
-            .build()));
+    setEndingSelection(SelectionInDOMTree::Builder()
+                           .collapse(endingPosition)
+                           .setIsDirectional(endingSelection().isDirectional())
+                           .build());
   }
 
   // Handle the case where there is a typing style.