Add a Cocoa version of the auto-dismissing dialog.

Add a Cocoa version of the auto-dismissing dialog.

BUG=629964
Committed: https://crrev.com/299fae9167303841d20117ae42658821b69dfdbe
Cr-Commit-Position: refs/heads/master@{#428133}

[Avi (use Gerrit), 2016-10-26 21:18:55]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 21:19:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-10-26 22:08:08]

avi@chromium.org changed reviewers:
+ rsesek@chromium.org

[Avi (use Gerrit), 2016-10-26 22:08:09]

Robert, you're the main reviewer, as this is all Cocoa all the time.

Peter, you're CC here; you reviewed the Views version, and if you want to know
how the Mac version fits in, here you go.

[commit-bot: I haz the power, 2016-10-26 22:35:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 22:35:51]

Dry run: This issue passed the CQ dry run.

[Robert Sesek, 2016-10-27 15:17:24]

LGTM

https://codereview.chromium.org/2450173003/diff/1/chrome/browser/ui/javascrip...
File chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.mm (right):

https://codereview.chromium.org/2450173003/diff/1/chrome/browser/ui/javascrip...
chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.mm:108:
[[NSTextField alloc] initWithFrame:NSMakeRect(0, 0, 460, 22)]);
Where do these values come from?

https://codereview.chromium.org/2450173003/diff/1/chrome/browser/ui/javascrip...
File chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
(right):

https://codereview.chromium.org/2450173003/diff/1/chrome/browser/ui/javascrip...
chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc:108: #if
defined(OS_MACOSX)
Alternatively, this block could be in JavaScriptDialog::Create.

[Avi (use Gerrit), 2016-10-27 18:40:15]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 18:41:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-10-27 18:41:22]

https://codereview.chromium.org/2450173003/diff/1/chrome/browser/ui/javascrip...
File chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.mm (right):

https://codereview.chromium.org/2450173003/diff/1/chrome/browser/ui/javascrip...
chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.mm:108:
[[NSTextField alloc] initWithFrame:NSMakeRect(0, 0, 460, 22)]);
On 2016/10/27 15:17:24, Robert Sesek wrote:
> Where do these values come from?

The height, 22, is the standard height of an NSTextField.

The width is a bit reverse engineered. Our ConstrainedWindowAlert happens to be
500px wide, and the left and right insets are 20px, so 460 makes the field fill
the dialog's width without causing the dialog to be wider.

https://codereview.chromium.org/2450173003/diff/1/chrome/browser/ui/javascrip...
File chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
(right):

https://codereview.chromium.org/2450173003/diff/1/chrome/browser/ui/javascrip...
chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc:108: #if
defined(OS_MACOSX)
On 2016/10/27 15:17:24, Robert Sesek wrote:
> Alternatively, this block could be in JavaScriptDialog::Create.

Yes, that would be cleaner. Done.

[commit-bot: I haz the power, 2016-10-27 20:04:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 20:04:50]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Avi (use Gerrit), 2016-10-27 20:19:06]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-10-27 20:19:07]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2450173003/#ps20001
(title: "rsesek")

[commit-bot: I haz the power, 2016-10-27 20:19:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 21:05:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-27 21:07:02]

Description was changed from

==========
Add a Cocoa version of the auto-dismissing dialog.

BUG=629964
==========

to

==========
Add a Cocoa version of the auto-dismissing dialog.

BUG=629964

Committed: https://crrev.com/299fae9167303841d20117ae42658821b69dfdbe
Cr-Commit-Position: refs/heads/master@{#428133}
==========

[commit-bot: I haz the power, 2016-10-27 21:07:03]

Patchset 2 (id:??) landed as
https://crrev.com/299fae9167303841d20117ae42658821b69dfdbe
Cr-Commit-Position: refs/heads/master@{#428133}