chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h - Issue 2450173003: Add a Cocoa version of the auto-dismissing dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h

Issue 2450173003: Add a Cocoa version of the auto-dismissing dialog. (Closed)

Patch Set: rsesek Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.mm ('k') | chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h

diff --git a/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h

index 3ce43989cbd488f7dfdc1c34735ab38450f1c513..dae643be2514cd3533d8953a6bdad7a5db48d331 100644

--- a/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h

+++ b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h

@@ -10,6 +10,7 @@

#include "base/macros.h"

#include "base/memory/weak_ptr.h"

#include "chrome/browser/ui/browser_list_observer.h"

+#include "chrome/browser/ui/javascript_dialogs/javascript_dialog.h"

#include "content/public/browser/javascript_dialog_manager.h"

#include "content/public/browser/web_contents_observer.h"

#include "content/public/browser/web_contents_user_data.h"

@@ -68,7 +69,7 @@ class JavaScriptDialogTabHelper

const base::string16& user_input);

// The dialog being displayed on the observed WebContents.

- base::WeakPtr<JavaScriptDialogViews> dialog_;

+ base::WeakPtr<JavaScriptDialog> dialog_;

// The callback provided for when the dialog is closed. Usually the dialog

// itself calls it, but in the cases where the dialog is closed not by the