Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2450093002: Read the selected text explicitly when focusing a texdt field (Closed)

Created:
4 years, 1 month ago by David Tseng
Modified:
4 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Read the selected text explicitly when focusing a texdt field This makes value output prefer output of selected text if available; otherwise, read the entire value. TEST=focus text fields in a variety of ways: - tab - ChromeVox commands Verify that on first focus, we don't manipulate the selection (chromevox_tests cover this well). Verify that in all other cases, including continuing to move inside of an editable, selection is moved. BUG=656353 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3e79fe872b6b9b759a4962cc820d32ee97bd71af Cr-Commit-Position: refs/heads/master@{#427747}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
David Tseng
4 years, 1 month ago (2016-10-25 22:40:58 UTC) #4
dmazzoni
lgtm
4 years, 1 month ago (2016-10-26 15:58:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450093002/1
4 years, 1 month ago (2016-10-26 17:04:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 18:16:11 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 18:21:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e79fe872b6b9b759a4962cc820d32ee97bd71af
Cr-Commit-Position: refs/heads/master@{#427747}

Powered by Google App Engine
This is Rietveld 408576698