chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js - Issue 2450093002: Read the selected text explicitly when focusing a texdt field

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Issue 2450093002: Read the selected text explicitly when focusing a texdt field (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

index 9c06328cc2428098cc4c9e5cb0989e5c66094060..461441207606fca2118ca47a2fa5ee0f0275d221 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

@@ -489,7 +489,14 @@ Background.prototype = {

this.pageSel_.select();

}

} else {

- range.select();

+ // Ensure we don't select the editable when we first encounter it.

+ var lca = null;

+ if (range.start.node && prevRange.start.node) {

+ lca = AutomationUtil.getLeastCommonAncestor(prevRange.start.node,

+ range.start.node);

+ }

+ if (!lca || lca.state.editable || !range.start.node.state.editable)

+ range.select();

}

o.withRichSpeechAndBraille(