Issue 245009: L10N pass through download item and download shelf....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 245009: L10N pass through download item and download shelf.... (Closed)

Created:
11 years, 3 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com, John Grabowski, Paul Godavari, pam+watch_chromium.org, ben+cc_chromium.org, Nico

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

L10N pass through download item and download shelf. - l10n the menus - l10n the dangerous item buttons - make view auto size for the dangerous item buttons TEST=download shelf item buttons and menus are localized BUG=20529 BUG=20530 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27242

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+283 lines, -79 lines)			Patch
M	chrome/app/nibs/DownloadItem.xib	View	29 chunks	+236 lines, -77 lines	0 comments	Download
M	chrome/app/nibs/DownloadShelf.xib	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/download_item_controller.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/download_item_controller.mm	View	2 chunks	+39 lines, -0 lines	1 comment	Download
M	chrome/chrome.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

lg http://codereview.chromium.org/245009/diff/1/5 File chrome/browser/cocoa/download_item_controller.mm (right): http://codereview.chromium.org/245009/diff/1/5#newcode95 Line 95: // Since the shelf keeps relaying out ...

11 years, 3 months ago (2009-09-25 20:20:41 UTC) #2

Nico

11 years, 1 month ago (2009-11-09 02:48:51 UTC) #3

> I guess I'm confused, what wasn't working from an L10N pov? =A0I thought
> http://codereview.chromium.org/245009 already had everything sizing
> correctly?

Oh, everything works fine, it's just that this way is neater because
it uses GTMUI stuff instead of explicit code. See the code deletions
in download_shelf_controller.mm. Also, it now uses a button instead of
a NSTextView for the link, which is nicer too.

(And the CL you linked mostly changed the download item handling, not
the download shelf handling)

Expand Messages | Collapse Messages