chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java - Issue 2449943002: Add pending line item support for web payments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Issue 2449943002: Add pending line item support for web payments. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/values-v17/styles.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/payments/ui/LineItem.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

index ae52a2f87e2bc144132631c3624ac569747eb7c1..9e4d80e067428f358ab246e48c7d27ef11b6cf58 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

@@ -567,7 +567,7 @@ public class PaymentRequestImpl implements PaymentRequest, PaymentRequestUI.Clie

LineItem uiTotal = new LineItem(

Mathieu 2016/10/26 02:04:59 nit: can you add a comment saying that the total i

please use gerrit instead 2016/10/26 13:48:16 Done.

details.total.label, formatter.getFormattedCurrencyCode(),

- formatter.format(details.total.amount.value));

+ formatter.format(details.total.amount.value), false);

List<LineItem> uiLineItems = getValidatedLineItems(details.displayItems, totalCurrency,

formatter);

@@ -632,7 +632,8 @@ public class PaymentRequestImpl implements PaymentRequest, PaymentRequestUI.Clie

// Value should be in correct format.

if (!formatter.isValidAmountValue(item.amount.value)) return null;

- result.add(new LineItem(item.label, "", formatter.format(item.amount.value)));

+ result.add(new LineItem(

+ item.label, "", formatter.format(item.amount.value), item.pending));

}

return result;