Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2449883002: Revert of [modules] Add partial support for debug-scopes. (Closed)

Created:
4 years, 1 month ago by Michael Achenbach
Modified:
4 years, 1 month ago
Reviewers:
neis, adamk, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [modules] Add partial support for debug-scopes. (patchset #1 id:1 of https://codereview.chromium.org/2445683002/ ) Reason for revert: Breaks https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/9349 Original issue's description: > [modules] Add partial support for debug-scopes. > > Setting variables is not yet implemented.. > > R=adamk@chromium.org > BUG=v8:1569 TBR=adamk@chromium.org,yangguo@chromium.org,neis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1569 Committed: https://crrev.com/de52faf948a9fac550f1ae3fd3f4a28fa8335652 Cr-Commit-Position: refs/heads/master@{#40564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1247 lines) Patch
M src/ast/scopeinfo.cc View 3 chunks +6 lines, -45 lines 0 comments Download
M src/contexts.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug-scopes.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/debug/debug-scopes.cc View 3 chunks +8 lines, -48 lines 0 comments Download
M src/debug/mirrors.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.h View 2 chunks +0 lines, -13 lines 0 comments Download
D test/mjsunit/modules-debug-scopes1.js View 1 chunk +0 lines, -897 lines 0 comments Download
D test/mjsunit/modules-debug-scopes2.js View 1 chunk +0 lines, -239 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [modules] Add partial support for debug-scopes.
4 years, 1 month ago (2016-10-25 12:55:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449883002/1
4 years, 1 month ago (2016-10-25 12:55:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 12:55:28 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:12:40 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de52faf948a9fac550f1ae3fd3f4a28fa8335652
Cr-Commit-Position: refs/heads/master@{#40564}

Powered by Google App Engine
This is Rietveld 408576698