[modules] Add partial support for debug-scopes.

Reland: [modules] Add partial support for debug-scopes.

Setting variables is not yet implemented.

R=adamk@chromium.org
BUG=v8:1569
Committed: https://crrev.com/9c558d7bd96810c2852feadf04dacd69160d0baf
Cr-Commit-Position: refs/heads/master@{#40566}

[adamk, 2016-10-24 10:52:17]

adamk@chromium.org changed reviewers:
+ yangguo@chromium.org

[adamk, 2016-10-24 10:52:18]

+yangguo for debug

lgtm once the TDZ test is added

https://codereview.chromium.org/2445683002/diff/1/test/mjsunit/modules-debug-...
File test/mjsunit/modules-debug-scopes2.js (right):

https://codereview.chromium.org/2445683002/diff/1/test/mjsunit/modules-debug-...
test/mjsunit/modules-debug-scopes2.js:54:
assertPropertiesEqual(scope1.scopeObject().value(),
scope2.scopeObject().value());
Over 80 characters here and various places below. We should really be using
clang-format on our JS, but I'm guessing that's harder to set up than it should
be.

https://codereview.chromium.org/2445683002/diff/1/test/mjsunit/modules-debug-...
test/mjsunit/modules-debug-scopes2.js:186: // Actual tests.
Can you also add a test with an export and an import in tdz?

[adamk, 2016-10-24 10:58:20]

https://codereview.chromium.org/2445683002/diff/1/test/mjsunit/modules-debug-...
File test/mjsunit/modules-debug-scopes2.js (right):

https://codereview.chromium.org/2445683002/diff/1/test/mjsunit/modules-debug-...
test/mjsunit/modules-debug-scopes2.js:186: // Actual tests.
On 2016/10/24 10:52:18, adamk wrote:
> Can you also add a test with an export and an import in tdz?

As neis kindly points out, the test immediately below this is testing this
behavior.

[Yang, 2016-10-25 10:39:15]

On 2016/10/24 10:58:20, adamk wrote:
>
https://codereview.chromium.org/2445683002/diff/1/test/mjsunit/modules-debug-...
> File test/mjsunit/modules-debug-scopes2.js (right):
> 
>
https://codereview.chromium.org/2445683002/diff/1/test/mjsunit/modules-debug-...
> test/mjsunit/modules-debug-scopes2.js:186: // Actual tests.
> On 2016/10/24 10:52:18, adamk wrote:
> > Can you also add a test with an export and an import in tdz?
> 
> As neis kindly points out, the test immediately below this is testing this
> behavior.

lgtm.

[neis, 2016-10-25 10:41:39]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2016-10-25 10:41:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 12:29:50]

Committed patchset #1 (id:1)

[Michael Achenbach, 2016-10-25 12:55:08]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2449883002/ by machenbach@chromium.org.

The reason for reverting is: Breaks
https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds....

[Michael Achenbach, 2016-10-25 12:59:09]

Also on linux:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/...

[neis, 2016-10-25 14:09:09]

Description was changed from

==========
[modules] Add partial support for debug-scopes.

Setting variables is not yet implemented..

R=adamk@chromium.org
BUG=v8:1569
==========

to

==========
Reland: [modules] Add partial support for debug-scopes.

Setting variables is not yet implemented..

R=adamk@chromium.org
BUG=v8:1569
==========

[neis, 2016-10-25 14:09:17]

Description was changed from

==========
Reland: [modules] Add partial support for debug-scopes.

Setting variables is not yet implemented..

R=adamk@chromium.org
BUG=v8:1569
==========

to

==========
Reland: [modules] Add partial support for debug-scopes.

Setting variables is not yet implemented.

R=adamk@chromium.org
BUG=v8:1569
==========

[neis, 2016-10-25 14:10:06]

The CQ bit was checked by neis@chromium.org

[neis, 2016-10-25 14:10:07]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org,
yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2445683002/#ps20001
(title: "Fix handle bug.")

[commit-bot: I haz the power, 2016-10-25 14:10:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 14:39:13]

Description was changed from

==========
Reland: [modules] Add partial support for debug-scopes.

Setting variables is not yet implemented.

R=adamk@chromium.org
BUG=v8:1569
==========

to

==========
Reland: [modules] Add partial support for debug-scopes.

Setting variables is not yet implemented.

R=adamk@chromium.org
BUG=v8:1569
==========

[commit-bot: I haz the power, 2016-10-25 14:39:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:12:25]

Description was changed from

==========
Reland: [modules] Add partial support for debug-scopes.

Setting variables is not yet implemented.

R=adamk@chromium.org
BUG=v8:1569
==========

to

==========
[modules] Add partial support for debug-scopes.

Setting variables is not yet implemented..

R=adamk@chromium.org
BUG=v8:1569

Committed: https://crrev.com/ee2f80c6bd7cf89b98149ef9d640f5f6fc52124d
Cr-Commit-Position: refs/heads/master@{#40559}
==========

[commit-bot: I haz the power, 2016-11-17 22:12:26]

Patchset 2 (id:??) landed as
https://crrev.com/ee2f80c6bd7cf89b98149ef9d640f5f6fc52124d
Cr-Commit-Position: refs/heads/master@{#40559}

[commit-bot: I haz the power, 2016-11-17 22:12:46]

Description was changed from

==========
[modules] Add partial support for debug-scopes.

Setting variables is not yet implemented..

R=adamk@chromium.org
BUG=v8:1569

Committed: https://crrev.com/ee2f80c6bd7cf89b98149ef9d640f5f6fc52124d
Cr-Commit-Position: refs/heads/master@{#40559}
==========

to

==========
Reland: [modules] Add partial support for debug-scopes.

Setting variables is not yet implemented.

R=adamk@chromium.org
BUG=v8:1569

Committed: https://crrev.com/9c558d7bd96810c2852feadf04dacd69160d0baf
Cr-Commit-Position: refs/heads/master@{#40566}
==========

[commit-bot: I haz the power, 2016-11-17 22:12:47]

Patchset 2 (id:??) landed as
https://crrev.com/9c558d7bd96810c2852feadf04dacd69160d0baf
Cr-Commit-Position: refs/heads/master@{#40566}