Removing CSPSourceList level up to SourceListDirective.

Removing CSPSourceList level up to SourceListDirective.

BUG=647588
Committed: https://crrev.com/20ffd3bc663646ac5e37bb2f61f93cc0c223f8eb
Cr-Commit-Position: refs/heads/master@{#428322}

[amalika, 2016-10-26 11:32:22]

The CQ bit was checked by amalika@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 11:32:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amalika, 2016-10-26 11:38:28]

Patchset #1 (id:1) has been deleted

[amalika, 2016-10-26 12:02:27]

Patchset #1 (id:20001) has been deleted

[amalika, 2016-10-26 12:02:28]

Patchset #1 (id:20001) has been deleted

[amalika, 2016-10-26 12:04:52]

amalika@google.com changed reviewers:
+ mkwst@chromium.org

[amalika, 2016-10-26 12:04:53]

https://codereview.chromium.org/2449873004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/csp/SourceListDirective.h (right):

https://codereview.chromium.org/2449873004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/SourceListDirective.h:10: #include
"core/frame/csp/CSPSource.h"
CSPSourceList also included 
#include "platform/Crypto.h"
#include "platform/heap/Handle.h"

but it seemed to compile without so I didnt include them.

[amalika, 2016-10-26 12:07:27]

The CQ bit was checked by amalika@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 12:07:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mike West, 2016-10-26 13:07:05]

LGTM % comments.

On 2016/10/26 at 12:04:53, amalika wrote:
>
https://codereview.chromium.org/2449873004/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/frame/csp/SourceListDirective.h (right):
> 
>
https://codereview.chromium.org/2449873004/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/frame/csp/SourceListDirective.h:10: #include
"core/frame/csp/CSPSource.h"
> CSPSourceList also included 
> #include "platform/Crypto.h"

Please include this for `DigestValue`.

> #include "platform/heap/Handle.h"

Yup, I don't think we need this one anymore.

> but it seemed to compile without so I didnt include them.

They're transitively included from another file, but we try to "include what we
use" to avoid that kind of indirection.

https://codereview.chromium.org/2449873004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/csp/SourceListDirective.h (right):

https://codereview.chromium.org/2449873004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/SourceListDirective.h:42: bool
allowNonce(String nonce) const;
Why change this to a copy?

[commit-bot: I haz the power, 2016-10-26 13:08:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 13:08:39]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[amalika, 2016-10-27 09:22:38]

Patchset #2 (id:60001) has been deleted

[amalika, 2016-10-27 11:26:38]

Patchset #3 (id:100001) has been deleted

[amalika, 2016-10-27 12:34:19]

https://codereview.chromium.org/2449873004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp (right):

https://codereview.chromium.org/2449873004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp:94: String
nonceStripped = nonce.stripWhiteSpace();
Changed this to strip white space inside!

[Mike West, 2016-10-27 14:13:48]

Still LGTM. Land it! :)

[Mike West, 2016-10-27 14:14:22]

Actually, can you add a bug link (to the main bug) to the CL description?

[amalika, 2016-10-27 14:17:35]

Description was changed from

==========
Removing CSPSourceList level up to SourceListDirective.

BUG=
==========

to

==========
Removing CSPSourceList level up to SourceListDirective.

BUG=647588
==========

[amalika, 2016-10-27 14:17:49]

The CQ bit was checked by amalika@google.com

[commit-bot: I haz the power, 2016-10-27 14:18:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 15:23:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 15:23:26]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[amalika, 2016-10-28 08:34:58]

The CQ bit was checked by amalika@google.com

[commit-bot: I haz the power, 2016-10-28 08:35:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 09:11:14]

Committed patchset #3 (id:120001)

[commit-bot: I haz the power, 2016-10-28 09:13:05]

Description was changed from

==========
Removing CSPSourceList level up to SourceListDirective.

BUG=647588
==========

to

==========
Removing CSPSourceList level up to SourceListDirective.

BUG=647588

Committed: https://crrev.com/20ffd3bc663646ac5e37bb2f61f93cc0c223f8eb
Cr-Commit-Position: refs/heads/master@{#428322}
==========

[commit-bot: I haz the power, 2016-10-28 09:13:06]

Patchset 3 (id:??) landed as
https://crrev.com/20ffd3bc663646ac5e37bb2f61f93cc0c223f8eb
Cr-Commit-Position: refs/heads/master@{#428322}