[NTP Snippets] Another round of clang-tidy cleanups

components/ntp_snippets/remote/ntp_snippets_fetcher.h

Index: components/ntp_snippets/remote/ntp_snippets_fetcher.h
diff --git a/components/ntp_snippets/remote/ntp_snippets_fetcher.h b/components/ntp_snippets/remote/ntp_snippets_fetcher.h
index f5bbf27412cc229053c8a01e15988a324e07afc0..da4a23cc3337ad2d6a01086ca0a81cbc155599ce 100644
--- a/components/ntp_snippets/remote/ntp_snippets_fetcher.h
+++ b/components/ntp_snippets/remote/ntp_snippets_fetcher.h
@@ -169,17 +169,18 @@ class NTPSnippetsFetcher : public OAuth2TokenService::Consumer,
   };
 
   struct RequestParams {
-    FetchAPI fetch_api;
+    FetchAPI fetch_api = CHROME_READER_API;
     std::string obfuscated_gaia_id;
-    bool only_return_personalized_results;
+    bool only_return_personalized_results = false;
     std::string user_locale;
     std::set<std::string> host_restricts;
     std::set<std::string> excluded_ids;
-    int count_to_fetch;
-    bool interactive_request;
+    int count_to_fetch = 0;
+    bool interactive_request = false;
     std::string user_class;
-    translate::LanguageModel::LanguageInfo ui_language;
-    translate::LanguageModel::LanguageInfo other_top_language;
+    translate::LanguageModel::LanguageInfo ui_language = {std::string(), 0.0f};

[Bernhard Bauer, 2016/10/26 08:52:04]

Hm. I'd be tempted to instead give LanguageInfo an empty constructor, so we'd
avoid using uninitialized values by accident.

[Marc Treib, 2016/10/26 09:19:18]

You're right of course - I was being lazy and not touching stuff we don't own...
Done.

+    translate::LanguageModel::LanguageInfo other_top_language = {std::string(),
+                                                                 0.0f};

[Marc Treib, 2016/10/26 08:23:54]

All this isn't completely clang-tidy-mandated - it just complained that some of
the initializers in the initializer list in the .cc are redundant (e.g. the
"user_locale()" did nothing). I decided to just move everything here instead of
leaving just some of the initializers in the .cc.

 
     RequestParams();
     ~RequestParams();