[NTP Snippets] Another round of clang-tidy cleanups

components/ntp_snippets/remote/ntp_snippets_fetcher.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NTP_SNIPPETS_REMOTE_NTP_SNIPPETS_FETCHER_H_
 #define COMPONENTS_NTP_SNIPPETS_REMOTE_NTP_SNIPPETS_FETCHER_H_
 
 #include <memory>
 #include <set>
 #include <string>
@@ skipping 151 matching lines @@
                            BuildRequestWithUILanguageOnly);
   FRIEND_TEST_ALL_PREFIXES(NTPSnippetsFetcherTest,
                            BuildRequestWithOtherLanguageOnly);
 
   enum FetchAPI {
     CHROME_READER_API,
     CHROME_CONTENT_SUGGESTIONS_API,
   };
 
   struct RequestParams {
-    FetchAPI fetch_api;
+    FetchAPI fetch_api = CHROME_READER_API;
     std::string obfuscated_gaia_id;
-    bool only_return_personalized_results;
+    bool only_return_personalized_results = false;
     std::string user_locale;
     std::set<std::string> host_restricts;
     std::set<std::string> excluded_ids;
-    int count_to_fetch;
-    bool interactive_request;
+    int count_to_fetch = 0;
+    bool interactive_request = false;
     std::string user_class;
-    translate::LanguageModel::LanguageInfo ui_language;
-    translate::LanguageModel::LanguageInfo other_top_language;
+    translate::LanguageModel::LanguageInfo ui_language = {std::string(), 0.0f};

[Bernhard Bauer, 2016/10/26 08:52:04]

Hm. I'd be tempted to instead give LanguageInfo an empty constructor, so we'd
avoid using uninitialized values by accident.

[Marc Treib, 2016/10/26 09:19:18]

You're right of course - I was being lazy and not touching stuff we don't own...
Done.

+    translate::LanguageModel::LanguageInfo other_top_language = {std::string(),
+                                                                 0.0f};

[Marc Treib, 2016/10/26 08:23:54]

All this isn't completely clang-tidy-mandated - it just complained that some of
the initializers in the initializer list in the .cc are redundant (e.g. the
"user_locale()" did nothing). I decided to just move everything here instead of
leaving just some of the initializers in the .cc.

 
     RequestParams();
     ~RequestParams();
 
     std::string BuildRequest();
   };
 
   void FetchSnippetsImpl(const GURL& url,
                          const std::string& auth_header,
                          const std::string& request);
@@ skipping 90 matching lines @@
   // When a token request gets canceled, we want to retry once.
   bool oauth_token_retried_;
 
   base::WeakPtrFactory<NTPSnippetsFetcher> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(NTPSnippetsFetcher);
 };
 }  // namespace ntp_snippets
 
 #endif  // COMPONENTS_NTP_SNIPPETS_REMOTE_NTP_SNIPPETS_FETCHER_H_