[NTP Snippets] Another round of clang-tidy cleanups

[NTP Snippets] Another round of clang-tidy cleanups

BUG=none

Committed: https://crrev.com/8d5ceb5cfc41d728714bc94750d28062e0f491e3
Cr-Commit-Position: refs/heads/master@{#428045}

[Marc Treib, 2016-10-25 17:08:24]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 17:08:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 18:37:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 18:37:16]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Marc Treib, 2016-10-26 08:23:54]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org

[Marc Treib, 2016-10-26 08:23:55]

PTAL!

https://codereview.chromium.org/2449873003/diff/1/components/ntp_snippets/rem...
File components/ntp_snippets/remote/ntp_snippets_fetcher.h (right):

https://codereview.chromium.org/2449873003/diff/1/components/ntp_snippets/rem...
components/ntp_snippets/remote/ntp_snippets_fetcher.h:183: 0.0f};
All this isn't completely clang-tidy-mandated - it just complained that some of
the initializers in the initializer list in the .cc are redundant (e.g. the
"user_locale()" did nothing). I decided to just move everything here instead of
leaving just some of the initializers in the .cc.

[Bernhard Bauer, 2016-10-26 08:52:05]

https://codereview.chromium.org/2449873003/diff/1/components/ntp_snippets/rem...
File components/ntp_snippets/remote/ntp_snippets_fetcher.h (right):

https://codereview.chromium.org/2449873003/diff/1/components/ntp_snippets/rem...
components/ntp_snippets/remote/ntp_snippets_fetcher.h:181:
translate::LanguageModel::LanguageInfo ui_language = {std::string(), 0.0f};
Hm. I'd be tempted to instead give LanguageInfo an empty constructor, so we'd
avoid using uninitialized values by accident.

[Marc Treib, 2016-10-26 09:19:19]

https://codereview.chromium.org/2449873003/diff/1/components/ntp_snippets/rem...
File components/ntp_snippets/remote/ntp_snippets_fetcher.h (right):

https://codereview.chromium.org/2449873003/diff/1/components/ntp_snippets/rem...
components/ntp_snippets/remote/ntp_snippets_fetcher.h:181:
translate::LanguageModel::LanguageInfo ui_language = {std::string(), 0.0f};
On 2016/10/26 08:52:04, Bernhard Bauer wrote:
> Hm. I'd be tempted to instead give LanguageInfo an empty constructor, so we'd
> avoid using uninitialized values by accident.

You're right of course - I was being lazy and not touching stuff we don't own...
Done.

[Marc Treib, 2016-10-26 09:21:05]

treib@chromium.org changed reviewers:
+ droger@chromium.org

[Marc Treib, 2016-10-26 09:21:05]

+droger for components/translate, PTAL!

https://codereview.chromium.org/2449873003/diff/20001/components/translate/co...
File components/translate/core/browser/language_model.h (right):

https://codereview.chromium.org/2449873003/diff/20001/components/translate/co...
components/translate/core/browser/language_model.h:38: float frequency = 0.0f;
Uninitialized values are Teh Evilz! :)
Unfortunately, adding this breaks c-style initialization for some reason, hence
the constructor above and the change in the .cc file.

[Bernhard Bauer, 2016-10-26 09:24:03]

lgtm

https://codereview.chromium.org/2449873003/diff/20001/components/translate/co...
File components/translate/core/browser/language_model.h (right):

https://codereview.chromium.org/2449873003/diff/20001/components/translate/co...
components/translate/core/browser/language_model.h:27: LanguageInfo() = default;
So, is there a rule for when to use {} and when to use = default? Seems like
this would work with {} as well, no?

[Marc Treib, 2016-10-26 09:29:40]

https://codereview.chromium.org/2449873003/diff/20001/components/translate/co...
File components/translate/core/browser/language_model.h (right):

https://codereview.chromium.org/2449873003/diff/20001/components/translate/co...
components/translate/core/browser/language_model.h:27: LanguageInfo() = default;
On 2016/10/26 09:24:02, Bernhard Bauer wrote:
> So, is there a rule for when to use {} and when to use = default? Seems like
> this would work with {} as well, no?

I don't know of any "official" rule - my personal one is to prefer "= default"
when possible. In the ctor below, it isn't - you can't have both an initializer
list and "= default".

[Marc Treib, 2016-10-26 11:04:59]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 11:05:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 11:15:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 11:15:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Marc Treib, 2016-10-26 12:26:55]

Patchset #4 (id:60001) has been deleted

[Marc Treib, 2016-10-26 12:27:20]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 12:27:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 13:12:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 13:12:45]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-10-27 13:17:48]

Ping droger@ - please look at components/translate, thanks!

[droger, 2016-10-27 14:14:06]

lgtm

[Marc Treib, 2016-10-27 14:50:07]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 14:50:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 16:09:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 16:09:39]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-10-27 16:20:36]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2016-10-27 16:20:36]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
droger@chromium.org
Link to the patchset: https://codereview.chromium.org/2449873003/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-27 16:20:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 16:25:25]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-10-27 16:29:52]

Description was changed from

==========
[NTP Snippets] Another round of clang-tidy cleanups

BUG=none
==========

to

==========
[NTP Snippets] Another round of clang-tidy cleanups

BUG=none

Committed: https://crrev.com/8d5ceb5cfc41d728714bc94750d28062e0f491e3
Cr-Commit-Position: refs/heads/master@{#428045}
==========

[commit-bot: I haz the power, 2016-10-27 16:29:53]

Patchset 5 (id:??) landed as
https://crrev.com/8d5ceb5cfc41d728714bc94750d28062e0f491e3
Cr-Commit-Position: refs/heads/master@{#428045}