DevTools: fix rounding of scale in device mode

DevTools: fix rounding of scale in device mode

While resizing the DevTools viewport to be smaller than the emulated device's
screen size in responsive mode, _calculateAndEmulate() clamps the emulated
screen size to preferredScaledWidth/Height(). The condition to do so checks
whether the screen's dimensions are greater than the preferred-scaled
dimensions. The sharp scale calculator in calculateFitScale() would find a scale
nearby the precise value that would result in integer screen sizes.

However, it was possible for the sharp scale to be greater than the actual
scale, which resulted in a smaller preferredScaledWidth/Height() than was
available. This edge case triggers the clamping condition, which led to
inaccurate widths/heights that differed from user input.

BUG=651123
Committed: https://crrev.com/2f5985ecef25664e1b6bba43b338683dd5d63c64
Cr-Commit-Position: refs/heads/master@{#427583}

[luoe, 2016-10-25 02:11:51]

Description was changed from

==========
DevTools: fix rounding of scale in device mode

BUG=651123
==========

to

==========
DevTools: fix rounding of scale in device mode

While resizing the DevTools viewport to be smaller than the emulated device's
screen size in responsive mode, _calculateAndEmulate() clamps the emulated
screen size the preferredScaledWidth/Height(). The condition to do so checks
whether the screen's dimensions are greater than the preferred-scaled
dimensions. The sharp scale calculator in calculateFitScale() would find a scale
nearby the precise value that would result in integer screen sizes.

However, it was possible for the sharp scale to be greater than the actual
scale, which resulted in a smaller preferredScaledWidth/Height() than was
available. This edge case triggers the clamping condition, which led to
inaccurate widths/heights that differed from user input.

BUG=651123
==========

[luoe, 2016-10-25 18:50:27]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 18:50:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[luoe, 2016-10-25 18:52:35]

luoe@chromium.org changed reviewers:
+ dgozman@chromium.org

[luoe, 2016-10-25 18:52:36]

These changes should be accounted for in tests in a separate CL:
https://codereview.chromium.org/2446113004

[commit-bot: I haz the power, 2016-10-25 21:07:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 21:07:01]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-10-26 01:55:55]

Nice stuff! lgtm

[luoe, 2016-10-26 03:05:10]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2016-10-26 03:05:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[luoe, 2016-10-26 03:05:38]

Description was changed from

==========
DevTools: fix rounding of scale in device mode

While resizing the DevTools viewport to be smaller than the emulated device's
screen size in responsive mode, _calculateAndEmulate() clamps the emulated
screen size the preferredScaledWidth/Height(). The condition to do so checks
whether the screen's dimensions are greater than the preferred-scaled
dimensions. The sharp scale calculator in calculateFitScale() would find a scale
nearby the precise value that would result in integer screen sizes.

However, it was possible for the sharp scale to be greater than the actual
scale, which resulted in a smaller preferredScaledWidth/Height() than was
available. This edge case triggers the clamping condition, which led to
inaccurate widths/heights that differed from user input.

BUG=651123
==========

to

==========
DevTools: fix rounding of scale in device mode

While resizing the DevTools viewport to be smaller than the emulated device's
screen size in responsive mode, _calculateAndEmulate() clamps the emulated
screen size to preferredScaledWidth/Height(). The condition to do so checks
whether the screen's dimensions are greater than the preferred-scaled
dimensions. The sharp scale calculator in calculateFitScale() would find a scale
nearby the precise value that would result in integer screen sizes.

However, it was possible for the sharp scale to be greater than the actual
scale, which resulted in a smaller preferredScaledWidth/Height() than was
available. This edge case triggers the clamping condition, which led to
inaccurate widths/heights that differed from user input.

BUG=651123
==========

[commit-bot: I haz the power, 2016-10-26 04:04:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 04:04:21]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

[commit-bot: I haz the power, 2016-10-26 04:05:23]

Description was changed from

==========
DevTools: fix rounding of scale in device mode

While resizing the DevTools viewport to be smaller than the emulated device's
screen size in responsive mode, _calculateAndEmulate() clamps the emulated
screen size to preferredScaledWidth/Height(). The condition to do so checks
whether the screen's dimensions are greater than the preferred-scaled
dimensions. The sharp scale calculator in calculateFitScale() would find a scale
nearby the precise value that would result in integer screen sizes.

However, it was possible for the sharp scale to be greater than the actual
scale, which resulted in a smaller preferredScaledWidth/Height() than was
available. This edge case triggers the clamping condition, which led to
inaccurate widths/heights that differed from user input.

BUG=651123
==========

to

==========
DevTools: fix rounding of scale in device mode

While resizing the DevTools viewport to be smaller than the emulated device's
screen size in responsive mode, _calculateAndEmulate() clamps the emulated
screen size to preferredScaledWidth/Height(). The condition to do so checks
whether the screen's dimensions are greater than the preferred-scaled
dimensions. The sharp scale calculator in calculateFitScale() would find a scale
nearby the precise value that would result in integer screen sizes.

However, it was possible for the sharp scale to be greater than the actual
scale, which resulted in a smaller preferredScaledWidth/Height() than was
available. This edge case triggers the clamping condition, which led to
inaccurate widths/heights that differed from user input.

BUG=651123

Committed: https://crrev.com/2f5985ecef25664e1b6bba43b338683dd5d63c64
Cr-Commit-Position: refs/heads/master@{#427583}
==========

[commit-bot: I haz the power, 2016-10-26 04:05:24]

Patchset 1 (id:??) landed as
https://crrev.com/2f5985ecef25664e1b6bba43b338683dd5d63c64
Cr-Commit-Position: refs/heads/master@{#427583}