Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1415)

Issue 2446113004: DevTools: add tests for device mode's responsive mode (Closed)

Created:
4 years, 1 month ago by luoe
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add tests for device mode's responsive mode This adds tests that reflect changes after this was fixed: https://codereview.chromium.org/2449763002 BUG=651123 Committed: https://crrev.com/ae4bf8b7cae4ad6190ce8efadf39c28eed0d2cc8 Cr-Commit-Position: refs/heads/master@{#427876}

Patch Set 1 #

Total comments: 4

Patch Set 2 : ac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -20 lines) Patch
A third_party/WebKit/LayoutTests/inspector/device-mode/device-mode-responsive.html View 1 chunk +77 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/device-mode/device-mode-responsive-expected.txt View 1 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js View 1 3 chunks +18 lines, -20 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (9 generated)
luoe
4 years, 1 month ago (2016-10-25 18:52:57 UTC) #2
dgozman
https://codereview.chromium.org/2446113004/diff/1/third_party/WebKit/LayoutTests/inspector/device-mode/device-mode-responsive-expected.txt File third_party/WebKit/LayoutTests/inspector/device-mode/device-mode-responsive-expected.txt (right): https://codereview.chromium.org/2446113004/diff/1/third_party/WebKit/LayoutTests/inspector/device-mode/device-mode-responsive-expected.txt#newcode1 third_party/WebKit/LayoutTests/inspector/device-mode/device-mode-responsive-expected.txt:1: 1 Missing output? https://codereview.chromium.org/2446113004/diff/1/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js File third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js (right): https://codereview.chromium.org/2446113004/diff/1/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js#newcode117 third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js:117: ...
4 years, 1 month ago (2016-10-26 18:35:23 UTC) #4
luoe
My bad, I left out the test results. They should be included now. Before the ...
4 years, 1 month ago (2016-10-26 18:56:51 UTC) #5
dgozman
lgtm. Thanks!
4 years, 1 month ago (2016-10-26 21:55:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446113004/20001
4 years, 1 month ago (2016-10-26 23:27:24 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 23:33:33 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 23:37:59 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ae4bf8b7cae4ad6190ce8efadf39c28eed0d2cc8
Cr-Commit-Position: refs/heads/master@{#427876}

Powered by Google App Engine
This is Rietveld 408576698