Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2449673002: Refactor InspectorWebPerfAgent: update lifecycle management to be per Local Frame root; replace hea… (Closed)
Patch Set: Update unittests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrame.h
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.h b/third_party/WebKit/Source/core/frame/LocalFrame.h
index 0723873e66894f10540509984d738af6a46d700a..777f4125a7084988c23a3f133ce4f9d10b620b91 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.h
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.h
@@ -60,11 +60,12 @@ class FrameSelection;
class FrameView;
class HTMLPlugInElement;
class InputMethodController;
+class InspectorWebPerfAgent;
+class InstrumentingAgents;
class InterfaceProvider;
class InterfaceRegistry;
class IntPoint;
class IntSize;
-class InstrumentingAgents;
class JSONObject;
class LayoutView;
class LayoutViewItem;
@@ -72,6 +73,7 @@ class LocalDOMWindow;
class NavigationScheduler;
class Node;
class NodeTraversal;
+class Performance;
template <typename Strategy>
class PositionWithAffinityTemplate;
class PluginData;
@@ -163,6 +165,13 @@ class CORE_EXPORT LocalFrame final : public Frame,
return m_instrumentingAgents.get();
}
+ const HeapHashSet<Member<Performance>>& webPerformanceObservers() {
+ return m_webPerformanceObservers;
+ }
+
+ void enableInspectorWebPerfAgent(Performance*);
+ void disableInspectorWebPerfAgent(Performance*);
+
// =========================================================================
// All public functions below this point are candidates to move out of
// LocalFrame into another class.
@@ -266,6 +275,8 @@ class CORE_EXPORT LocalFrame final : public Frame,
bool m_inViewSourceMode;
Member<InstrumentingAgents> m_instrumentingAgents;
+ Member<InspectorWebPerfAgent> m_inspectorWebPerfAgent;
+ HeapHashSet<Member<Performance>> m_webPerformanceObservers;
caseq 2016/10/31 22:41:54 Can you rather put that within the InspectorWebPer
panicker 2016/11/01 03:03:33 Done.
InterfaceProvider* const m_interfaceProvider;
InterfaceRegistry* const m_interfaceRegistry;

Powered by Google App Engine
This is Rietveld 408576698