Refactor InspectorWebPerfAgent: update lifecycle management to be per Local Frame root; replace hea…

third_party/WebKit/Source/core/frame/LocalFrame.h

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999-2001 Lars Knoll <knoll@kde.org>
  *                     1999-2001 Antti Koivisto <koivisto@kde.org>
  *                     2000-2001 Simon Hausmann <hausmann@kde.org>
  *                     2000-2001 Dirk Mueller <mueller@kde.org>
  *                     2000 Stefan Schimanski <1Stein@gmx.de>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
@@ skipping 42 matching lines @@
 class Element;
 template <typename Strategy>
 class EphemeralRangeTemplate;
 class EventHandler;
 class FloatSize;
 class FrameConsole;
 class FrameSelection;
 class FrameView;
 class HTMLPlugInElement;
 class InputMethodController;
+class InspectorWebPerfAgent;
+class InstrumentingAgents;
 class InterfaceProvider;
 class InterfaceRegistry;
 class IntPoint;
 class IntSize;
-class InstrumentingAgents;
 class JSONObject;
 class LayoutView;
 class LayoutViewItem;
 class LocalDOMWindow;
 class NavigationScheduler;
 class Node;
 class NodeTraversal;
+class Performance;
 template <typename Strategy>
 class PositionWithAffinityTemplate;
 class PluginData;
 class Range;
 class ScriptController;
 class SpellChecker;
 class WebFrameHostScheduler;
 class WebFrameScheduler;
 
 extern template class CORE_EXTERN_TEMPLATE_EXPORT Supplement<LocalFrame>;
@@ skipping 71 matching lines @@
   // change.
   // In addition, this function will always return true for a detached frame.
   // TODO(dcheng): Move this to LocalDOMWindow and figure out the right
   // behavior for detached windows.
   bool isCrossOriginSubframe() const;
 
   InstrumentingAgents* instrumentingAgents() {
     return m_instrumentingAgents.get();
   }
 
+  const HeapHashSet<Member<Performance>>& webPerformanceObservers() {
+    return m_webPerformanceObservers;
+  }
+
+  void enableInspectorWebPerfAgent(Performance*);
+  void disableInspectorWebPerfAgent(Performance*);
+
   // =========================================================================
   // All public functions below this point are candidates to move out of
   // LocalFrame into another class.
 
   // See GraphicsLayerClient.h for accepted flags.
   String layerTreeAsText(unsigned flags = 0) const;
 
   void setPrinting(bool printing,
                    const FloatSize& pageSize,
                    const FloatSize& originalPageSize,
@@ skipping 83 matching lines @@
   const Member<InputMethodController> m_inputMethodController;
 
   int m_navigationDisableCount;
 
   float m_pageZoomFactor;
   float m_textZoomFactor;
 
   bool m_inViewSourceMode;
 
   Member<InstrumentingAgents> m_instrumentingAgents;
+  Member<InspectorWebPerfAgent> m_inspectorWebPerfAgent;
+  HeapHashSet<Member<Performance>> m_webPerformanceObservers;

[caseq, 2016/10/31 22:41:54]

Can you rather put that within the InspectorWebPerfAgent? It seems to belong
there logically...

[panicker, 2016/11/01 03:03:33]

Done.

 
   InterfaceProvider* const m_interfaceProvider;
   InterfaceRegistry* const m_interfaceRegistry;
 };
 
 inline void LocalFrame::init() {
   m_loader.init();
 }
 
 inline LocalDOMWindow* LocalFrame::localDOMWindow() const {
@@ skipping 92 matching lines @@
   explicit ScopedFrameBlamer(LocalFrame*);
   ~ScopedFrameBlamer();
 
  private:
   Member<LocalFrame> m_frame;
 };
 
 }  // namespace blink
 
 #endif  // LocalFrame_h