[Contextual Search] Add support for a static icon

[Contextual Search] Add support for a static icon

Currently the Bar may show either an animated sprite or a thumbnail. Add
support for a static icon which may be shown instead of a thumbnail.

BUG=657063
Committed: https://crrev.com/e921d19c2e0065d82252c13e4a13c7ffde3900b6
Cr-Commit-Position: refs/heads/master@{#427221}

[Theresa, 2016-10-24 23:18:08]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[Theresa, 2016-10-24 23:18:53]

twellington@chromium.org changed reviewers:
+ donnd@chromium.org

[Theresa, 2016-10-24 23:18:53]

ptal

[commit-bot: I haz the power, 2016-10-24 23:19:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Donn Denman, 2016-10-24 23:56:20]

LGTM with some tiny nits.

I wasn't sure I liked the terminology, since "static image" seemed contrary to
the dynamic loading thumbnail.  But now that I've read it I understand it's
contrary to the animated sprite, and I'm happy with it.  

I wonder if there's a good way to define our terms, but that's probably
overkill.  I'll just memorize "Static Image is either a Thumbnail or static
icon, as opposed to animated sprite."

Nit: typo in description (last line -- show/shown).

https://codereview.chromium.org/2449653002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchImageControl.java
(right):

https://codereview.chromium.org/2449653002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchImageControl.java:120:
if (mStaticIconVisible) return;
Nit: add a blank line after (since there's a return)?

https://codereview.chromium.org/2449653002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchImageControl.java:185:
* @return The height and width of the thumbnail in px.
Nit: change thumbnail to static image.

https://codereview.chromium.org/2449653002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchImageControl.java:204:
private void onStaticImageHidden() {
Nit: add javadoc.

https://codereview.chromium.org/2449653002/diff/20001/chrome/browser/android/...
File chrome/browser/android/compositor/layer/contextual_search_layer.cc (right):

https://codereview.chromium.org/2449653002/diff/20001/chrome/browser/android/...
chrome/browser/android/compositor/layer/contextual_search_layer.cc:480: float
thumbnail_y_offset =
Nit: change to static_image_y_offset.

[Theresa, 2016-10-25 00:27:21]

Description was changed from

==========
[Contextual Search] Add support for a static icon

Currently the Bar may show either an animated sprite or a thumbnail. Add
support for a static icon which may be show instead of a thumbnail.

BUG=657063
==========

to

==========
[Contextual Search] Add support for a static icon

Currently the Bar may show either an animated sprite or a thumbnail. Add
support for a static icon which may be shown instead of a thumbnail.

BUG=657063
==========

[Theresa, 2016-10-25 00:32:48]

https://codereview.chromium.org/2449653002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchImageControl.java
(right):

https://codereview.chromium.org/2449653002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchImageControl.java:120:
if (mStaticIconVisible) return;
On 2016/10/24 23:56:20, Donn Denman wrote:
> Nit: add a blank line after (since there's a return)?

Done.

https://codereview.chromium.org/2449653002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchImageControl.java:185:
* @return The height and width of the thumbnail in px.
On 2016/10/24 23:56:20, Donn Denman wrote:
> Nit: change thumbnail to static image.

Done.

https://codereview.chromium.org/2449653002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchImageControl.java:204:
private void onStaticImageHidden() {
On 2016/10/24 23:56:20, Donn Denman wrote:
> Nit: add javadoc.

Done.

https://codereview.chromium.org/2449653002/diff/20001/chrome/browser/android/...
File chrome/browser/android/compositor/layer/contextual_search_layer.cc (right):

https://codereview.chromium.org/2449653002/diff/20001/chrome/browser/android/...
chrome/browser/android/compositor/layer/contextual_search_layer.cc:480: float
thumbnail_y_offset =
On 2016/10/24 23:56:20, Donn Denman wrote:
> Nit: change to static_image_y_offset.

Done.

[Theresa, 2016-10-25 00:34:06]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2016-10-25 00:34:06]

The patchset sent to the CQ was uploaded after l-g-t-m from donnd@chromium.org
Link to the patchset: https://codereview.chromium.org/2449653002/#ps40001
(title: "Changes from donnd@ review")

[commit-bot: I haz the power, 2016-10-25 00:34:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 01:36:52]

Description was changed from

==========
[Contextual Search] Add support for a static icon

Currently the Bar may show either an animated sprite or a thumbnail. Add
support for a static icon which may be shown instead of a thumbnail.

BUG=657063
==========

to

==========
[Contextual Search] Add support for a static icon

Currently the Bar may show either an animated sprite or a thumbnail. Add
support for a static icon which may be shown instead of a thumbnail.

BUG=657063
==========

[commit-bot: I haz the power, 2016-10-25 01:36:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-25 01:39:17]

Description was changed from

==========
[Contextual Search] Add support for a static icon

Currently the Bar may show either an animated sprite or a thumbnail. Add
support for a static icon which may be shown instead of a thumbnail.

BUG=657063
==========

to

==========
[Contextual Search] Add support for a static icon

Currently the Bar may show either an animated sprite or a thumbnail. Add
support for a static icon which may be shown instead of a thumbnail.

BUG=657063

Committed: https://crrev.com/e921d19c2e0065d82252c13e4a13c7ffde3900b6
Cr-Commit-Position: refs/heads/master@{#427221}
==========

[commit-bot: I haz the power, 2016-10-25 01:39:18]

Patchset 3 (id:??) landed as
https://crrev.com/e921d19c2e0065d82252c13e4a13c7ffde3900b6
Cr-Commit-Position: refs/heads/master@{#427221}