[IndexedDB] Add Observer Tests

[IndexedDB] Add IDB Observer Tests

Adding pipelined IDB Observer tests. The pipeline is:
1. Init databases,
2. Add observers & start observer tests,
3. Perform database actions (in two stages).

These are split up so they can be executed in workers
or in the same frame. This does not include all cases
where we want to throw an exception, that will be in
a follow up patch.

Current Implementation and Future Scope: https://goo.gl/Y2dobn

Reference: https://github.com/WICG/indexed-db-observers/blob/gh-pages/EXPLAINER.md

BUG=609934
Committed: https://crrev.com/1bf48eaa4831b5fd0a78bcb5d9a36b63d2a8cf49
Cr-Commit-Position: refs/heads/master@{#428091}

[dmurph, 2016-10-24 23:43:15]

Description was changed from

==========
[IndexedDB] Add Observer Tests

Adding test for general observer behavior across browsing contexts.

Current Implementation and Future Scope: https://goo.gl/Y2dobn

Reference:
https://github.com/WICG/indexed-db-observers/blob/gh-pages/EXPLAINER.md

BUG=609934
==========

to

==========
[IndexedDB] Add IDB Observer Tests

Adding pipelined IDB Observer tests. The pipeline is:
1. Init databases,
2. Add observers & start observer tests,
3. Perform database actions (in two stages).

These are split up so they can be executed in workers
or in the same frame. This does not include all cases
where we want to throw an exception, that will be in
a follow up patch.

Current Implementation and Future Scope: https://goo.gl/Y2dobn

Reference:
https://github.com/WICG/indexed-db-observers/blob/gh-pages/EXPLAINER.md

BUG=609934
==========

[dmurph, 2016-10-24 23:43:16]

dmurph@chromium.org changed reviewers:
+ cmumford@chromium.org, haraken@chromium.org

[dmurph, 2016-10-24 23:45:59]

Hello Kentaro & Chris!

I've refactored Palak's test patch here:
https://codereview.chromium.org/2163213006/

In the following patch. I pipeline the test execution so we
can run any part of the test on any context, and I cover all of the valid
use-cases.

I still need to cover the exceptions, which will be in a following patch.

Thanks, and PTAL :)

Daniel

[haraken, 2016-10-25 07:27:26]

(Chris should be a better reviewer for this one :-)

[cmumford, 2016-10-25 17:57:31]

lgtm % small nit.

Note: storage/indexeddb/observer-workers.html failed for me, but only once, and
I was unable to reproduce. Sorry, no output.

https://codereview.chromium.org/2449563002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/storage/indexeddb/resources/observer-init.js
(right):

https://codereview.chromium.org/2449563002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/storage/indexeddb/resources/observer-init.js:38:
var os2 = db.createObjectStore('store2');
Nit: fix indent.

[dmurph, 2016-10-25 18:23:51]

Thanks!

https://codereview.chromium.org/2449563002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/storage/indexeddb/resources/observer-init.js
(right):

https://codereview.chromium.org/2449563002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/storage/indexeddb/resources/observer-init.js:38:
var os2 = db.createObjectStore('store2');
On 2016/10/25 17:57:30, cmumford wrote:
> Nit: fix indent.

Done.

[dmurph, 2016-10-25 18:28:15]

On 2016/10/25 07:27:26, haraken wrote:
> (Chris should be a better reviewer for this one :-)

Ok! Does that mean you're differing your review? Let me know, I don't want to
submit this to the CQ without making sure all reviewers give their OK.
(You don't need to review, I put you on here as you were on Palak's test patch.
But feel free if you want to :) ).

[dmurph, 2016-10-25 18:28:22]

The CQ bit was checked by dmurph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 18:29:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-10-25 18:29:47]

On 2016/10/25 18:28:15, dmurph wrote:
> On 2016/10/25 07:27:26, haraken wrote:
> > (Chris should be a better reviewer for this one :-)
> 
> Ok! Does that mean you're differing your review? Let me know, I don't want to
> submit this to the CQ without making sure all reviewers give their OK.
> (You don't need to review, I put you on here as you were on Palak's test
patch.
> But feel free if you want to :) ).

rs LGTM. This is purely about IDB stuff, so I'll defer this to Chris :)

[dmurph, 2016-10-25 18:43:11]

The CQ bit was unchecked by dmurph@chromium.org

[dmurph, 2016-10-25 18:43:15]

The CQ bit was checked by dmurph@chromium.org

[dmurph, 2016-10-25 18:43:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
cmumford@chromium.org
Link to the patchset: https://codereview.chromium.org/2449563002/#ps40001
(title: "nits and clarified [init] test name")

[commit-bot: I haz the power, 2016-10-25 18:43:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 19:49:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 19:49:36]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dmurph, 2016-10-25 21:32:39]

The CQ bit was checked by dmurph@chromium.org to run a CQ dry run

[dmurph, 2016-10-25 21:33:20]

Hi Chris,

Can you PTAL again? I did some changes to try to fix the strange error in the
*-frames.html, but I had no success. I think it should be fine as-is.

Thanks,
Daniel

[commit-bot: I haz the power, 2016-10-25 21:33:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 21:42:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 21:42:59]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dmurph, 2016-10-26 21:20:47]

Hello again,

After chatting with Josh I learned that I was doing bad things by requiring
state between tests (INIT and ACTIONS tests). I fixed this by creating an
indexeddb_observers_test wrapper to do all of this work on a per-test basis.

PTAL, I think it looks much cleaner now. I also created a couple more helper
functions, like a barrier.

[cmumford, 2016-10-26 22:16:18]

The CQ bit was checked by cmumford@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 22:16:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmurph, 2016-10-26 22:53:52]

The CQ bit was checked by dmurph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 22:54:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmurph, 2016-10-26 23:26:52]

The CQ bit was checked by dmurph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 23:27:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 00:43:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 00:43:45]

Dry run: This issue passed the CQ dry run.

[cmumford, 2016-10-27 16:12:50]

lgtm

[dmurph, 2016-10-27 18:38:00]

The CQ bit was checked by dmurph@chromium.org

[dmurph, 2016-10-27 18:38:00]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2449563002/#ps120001
(title: "Fixed errors in other tests, and marked observer tests as long")

[commit-bot: I haz the power, 2016-10-27 18:38:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 18:44:03]

Description was changed from

==========
[IndexedDB] Add IDB Observer Tests

Adding pipelined IDB Observer tests. The pipeline is:
1. Init databases,
2. Add observers & start observer tests,
3. Perform database actions (in two stages).

These are split up so they can be executed in workers
or in the same frame. This does not include all cases
where we want to throw an exception, that will be in
a follow up patch.

Current Implementation and Future Scope: https://goo.gl/Y2dobn

Reference:
https://github.com/WICG/indexed-db-observers/blob/gh-pages/EXPLAINER.md

BUG=609934
==========

to

==========
[IndexedDB] Add IDB Observer Tests

Adding pipelined IDB Observer tests. The pipeline is:
1. Init databases,
2. Add observers & start observer tests,
3. Perform database actions (in two stages).

These are split up so they can be executed in workers
or in the same frame. This does not include all cases
where we want to throw an exception, that will be in
a follow up patch.

Current Implementation and Future Scope: https://goo.gl/Y2dobn

Reference:
https://github.com/WICG/indexed-db-observers/blob/gh-pages/EXPLAINER.md

BUG=609934
==========

[commit-bot: I haz the power, 2016-10-27 18:44:05]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-10-27 19:01:41]

Description was changed from

==========
[IndexedDB] Add IDB Observer Tests

Adding pipelined IDB Observer tests. The pipeline is:
1. Init databases,
2. Add observers & start observer tests,
3. Perform database actions (in two stages).

These are split up so they can be executed in workers
or in the same frame. This does not include all cases
where we want to throw an exception, that will be in
a follow up patch.

Current Implementation and Future Scope: https://goo.gl/Y2dobn

Reference:
https://github.com/WICG/indexed-db-observers/blob/gh-pages/EXPLAINER.md

BUG=609934
==========

to

==========
[IndexedDB] Add IDB Observer Tests

Adding pipelined IDB Observer tests. The pipeline is:
1. Init databases,
2. Add observers & start observer tests,
3. Perform database actions (in two stages).

These are split up so they can be executed in workers
or in the same frame. This does not include all cases
where we want to throw an exception, that will be in
a follow up patch.

Current Implementation and Future Scope: https://goo.gl/Y2dobn

Reference:
https://github.com/WICG/indexed-db-observers/blob/gh-pages/EXPLAINER.md

BUG=609934

Committed: https://crrev.com/1bf48eaa4831b5fd0a78bcb5d9a36b63d2a8cf49
Cr-Commit-Position: refs/heads/master@{#428091}
==========

[commit-bot: I haz the power, 2016-10-27 19:01:43]

Patchset 7 (id:??) landed as
https://crrev.com/1bf48eaa4831b5fd0a78bcb5d9a36b63d2a8cf49
Cr-Commit-Position: refs/heads/master@{#428091}