third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp - Issue 2449563002: [IndexedDB] Add Observer Tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp

Issue 2449563002: [IndexedDB] Add Observer Tests (Closed)

Patch Set: Fixed errors in other tests, and marked observer tests as long Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp

index 95abf13fd943670ef41e1446a317e32a75b242fe..adbf771060987d8d2fbca24e2400b96bed90bcb2 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp

@@ -32,7 +32,6 @@ IDBObserver::IDBObserver(ScriptState* scriptState,

m_transaction(options.transaction()),

m_values(options.values()),

m_noRecords(options.noRecords()) {

- // TODO(palakj): Throw an exception if unknown operation type.

DCHECK_EQ(m_operationTypes.size(),

static_cast<size_t>(WebIDBOperationTypeCount));

m_operationTypes.reset();