Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2449443002: Convert editing/spelling/spelling.html with spellcheck_test (Closed)

Created:
4 years, 1 month ago by Xiaocheng
Modified:
4 years, 1 month ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/spelling/spelling.html with spellcheck_test This patch converts editing/spelling/spelling.html with spellcheck_test as a preparation of implementing idle time spellchecker, and renames it to spelling_after_newline.html to better summarize the test case. BUG=517298 Committed: https://crrev.com/b85bedf0657d101dfbf37ff17094de5bc859433d Cr-Commit-Position: refs/heads/master@{#427643}

Patch Set 1 #

Patch Set 2 : Done #

Messages

Total messages: 27 (18 generated)
Xiaocheng
PTAL.
4 years, 1 month ago (2016-10-25 01:19:36 UTC) #6
yosin_UTC9
lgtm BTW, how many numbers of tests will you convert to use spellcheck_test()?
4 years, 1 month ago (2016-10-25 01:21:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449443002/1
4 years, 1 month ago (2016-10-25 01:22:14 UTC) #9
Xiaocheng
On 2016/10/25 at 01:21:44, yosin wrote: > lgtm > > BTW, how many numbers of ...
4 years, 1 month ago (2016-10-25 01:23:45 UTC) #10
Xiaocheng
PTAL again after using the new spellcheck_test?
4 years, 1 month ago (2016-10-26 05:28:15 UTC) #17
yosin_UTC9
lgtm
4 years, 1 month ago (2016-10-26 08:53:15 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449443002/20001
4 years, 1 month ago (2016-10-26 08:53:31 UTC) #24
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 08:58:56 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 09:00:31 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b85bedf0657d101dfbf37ff17094de5bc859433d
Cr-Commit-Position: refs/heads/master@{#427643}

Powered by Google App Engine
This is Rietveld 408576698