Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2437703003: Enable IdleTimeSpellChecking in Blink Tests (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
3 years, 9 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable IdleTimeSpellChecking in Blink tests This patch enables the above mentioned Blink runtime enabled feature in Blink tests. BUG=671922 Review-Url: https://codereview.chromium.org/2437703003 Cr-Commit-Position: refs/heads/master@{#455656} Committed: https://chromium.googlesource.com/chromium/src/+/6ac6bd671fbbbe77fb3adc2847e0102cb995c57c

Patch Set 1 #

Patch Set 2 : idle checker Fri Oct 21 11:56:36 JST 2016 #

Patch Set 3 : Add runtime flag for idle time spellchecking #

Patch Set 4 : Naive idle time spellchecker #

Patch Set 5 : Tue Nov 1 17:45:07 JST 2016 #

Patch Set 6 : Wed Nov 9 19:50:17 JST 2016 #

Patch Set 7 : Thu Nov 17 18:03:30 JST 2016 #

Patch Set 8 : Add sequence number to undo steps #

Patch Set 9 : Wed Dec 7 11:01:21 JST 2016 #

Patch Set 10 : use undo stack to generate hot mode candidates #

Patch Set 11 : Do not check partial word during typing #

Patch Set 12 : Thu Dec 8 18:28:07 JST 2016 #

Patch Set 13 : Mon Dec 12 20:06:38 JST 2016 #

Patch Set 14 : Mon Jan 16 22:24:33 JST 2017 #

Patch Set 15 : Wed Jan 18 19:20:31 JST 2017 #

Patch Set 16 : 201602061733 #

Patch Set 17 : Fri Feb 17 16:05:37 PST 2017 #

Patch Set 18 : Fri Feb 17 16:33:00 PST 2017 #

Patch Set 19 : Fri Feb 17 17:21:19 PST 2017 #

Patch Set 20 : Fri Feb 17 17:26:50 PST 2017 #

Patch Set 21 : Fri Feb 17 17:59:51 PST 2017 #

Patch Set 22 : Thu Feb 23 16:46:35 PST 2017 #

Patch Set 23 : PST201702271618 #

Patch Set 24 : Mon Feb 27 17:00:53 PST 2017 #

Patch Set 25 : Thu Mar 2 17:37:48 PST 2017 #

Patch Set 26 : Thu Mar 2 20:26:48 PST 2017 #

Patch Set 27 : Fri Mar 3 11:05:49 PST 2017 #

Patch Set 28 : Fri Mar 3 11:08:40 PST 2017 #

Patch Set 29 : Fix WebFrameTests for idle time spell checker #

Patch Set 30 : Fri Mar 3 12:21:11 PST 2017 #

Patch Set 31 : Bug fix and add cold mode testing semantics #

Patch Set 32 : Add layout tests for cold mode checker #

Patch Set 33 : Add layout tests for cold mode checker #

Patch Set 34 : Rebase #

Patch Set 35 : Mon Mar 6 17:17:06 PST 2017 #

Patch Set 36 : Enable IdleTimeSpellChecking in Blink tests #

Patch Set 37 : Enable IdleTimeSpellChecking in Blink tests #

Patch Set 38 : Rebased Mar 8 #

Patch Set 39 : Rebase 201703081540 #

Patch Set 40 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 55 (48 generated)
Xiaocheng
Now that all implementation patches have passed review, it's time to push the status forward ...
3 years, 9 months ago (2017-03-08 01:49:09 UTC) #22
tkent
lgtm
3 years, 9 months ago (2017-03-08 01:50:29 UTC) #24
Xiaocheng
Whoops, there's a stupid mistake in editing/spelling/spelling-huge-text.html. I'll fix that first...
3 years, 9 months ago (2017-03-08 04:30:26 UTC) #36
yosin_UTC9
lgtm
3 years, 9 months ago (2017-03-09 01:21:26 UTC) #46
Xiaocheng
I'm committing it! (\o/)
3 years, 9 months ago (2017-03-09 03:34:07 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437703003/770001
3 years, 9 months ago (2017-03-09 03:41:20 UTC) #52
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 03:45:38 UTC) #55
Message was sent while issue was closed.
Committed patchset #40 (id:770001) as
https://chromium.googlesource.com/chromium/src/+/6ac6bd671fbbbe77fb3adc2847e0...

Powered by Google App Engine
This is Rietveld 408576698