Stop using webrtc::VideoCodec.codecSpecific

Stop using webrtc::VideoCodec.codecSpecific

Instead of reaching into an union, we use accessors.

BUG=webrtc:6603
Committed: https://crrev.com/a8215e602cdd32f863d9ab222486dee44b707065
Cr-Commit-Position: refs/heads/master@{#427948}

[hta - Chromium, 2016-10-26 11:25:45]

Description was changed from

==========
Stop using webrtc::VideoCodec.codecSpecific

Instead of reaching into an union, we use accessors.

BUG=webrtc:6603
==========

to

==========
Stop using webrtc::VideoCodec.codecSpecific

Instead of reaching into an union, we use accessors.

BUG=webrtc:6603
==========

[hta - Chromium, 2016-10-26 11:25:46]

hta@chromium.org changed reviewers:
+ wuchengli@chromium.org

[hta - Chromium, 2016-10-26 11:26:34]

Please review - this is part of a refactoring operation for webrtc, reducing the
visibility of unions for codec specific data.

Thanks!

[hta - Chromium, 2016-10-26 11:31:06]

The CQ bit was checked by hta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 11:31:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 12:21:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 12:21:51]

Dry run: This issue passed the CQ dry run.

[wuchengli, 2016-10-26 13:53:51]

https://codereview.chromium.org/2449353003/diff/1/content/renderer/media/gpu/...
File content/renderer/media/gpu/rtc_video_decoder_unittest.cc (right):

https://codereview.chromium.org/2449353003/diff/1/content/renderer/media/gpu/...
content/renderer/media/gpu/rtc_video_decoder_unittest.cc:185:
codec_.VP8()->feedbackModeOn = true;
Why this uses VP8()->feedbackModeOn and rtc_video_decoder.cc uses
VP8().feedbackModeOn?

[hta - Chromium, 2016-10-26 15:42:40]

On 2016/10/26 13:53:51, wuchengli wrote:
>
https://codereview.chromium.org/2449353003/diff/1/content/renderer/media/gpu/...
> File content/renderer/media/gpu/rtc_video_decoder_unittest.cc (right):
> 
>
https://codereview.chromium.org/2449353003/diff/1/content/renderer/media/gpu/...
> content/renderer/media/gpu/rtc_video_decoder_unittest.cc:185:
> codec_.VP8()->feedbackModeOn = true;
> Why this uses VP8()->feedbackModeOn and rtc_video_decoder.cc uses
> VP8().feedbackModeOn?

The const accessor returns a const reference, while the non-const accessor
returns a pointer. Thus, when you modify the value, you have to use -> - when
you only read the value, you will use .

[wuchengli, 2016-10-27 01:48:10]

On 2016/10/26 15:42:40, hta - Chromium wrote:
> On 2016/10/26 13:53:51, wuchengli wrote:
> >
>
https://codereview.chromium.org/2449353003/diff/1/content/renderer/media/gpu/...
> > File content/renderer/media/gpu/rtc_video_decoder_unittest.cc (right):
> > 
> >
>
https://codereview.chromium.org/2449353003/diff/1/content/renderer/media/gpu/...
> > content/renderer/media/gpu/rtc_video_decoder_unittest.cc:185:
> > codec_.VP8()->feedbackModeOn = true;
> > Why this uses VP8()->feedbackModeOn and rtc_video_decoder.cc uses
> > VP8().feedbackModeOn?
> 
> The const accessor returns a const reference, while the non-const accessor
> returns a pointer. Thus, when you modify the value, you have to use -> - when
> you only read the value, you will use .
I see.

[wuchengli, 2016-10-27 01:48:16]

lgtm

[hta - Chromium, 2016-10-27 05:33:30]

The CQ bit was checked by hta@chromium.org

[commit-bot: I haz the power, 2016-10-27 05:33:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 05:37:50]

Description was changed from

==========
Stop using webrtc::VideoCodec.codecSpecific

Instead of reaching into an union, we use accessors.

BUG=webrtc:6603
==========

to

==========
Stop using webrtc::VideoCodec.codecSpecific

Instead of reaching into an union, we use accessors.

BUG=webrtc:6603
==========

[commit-bot: I haz the power, 2016-10-27 05:37:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-27 05:41:20]

Description was changed from

==========
Stop using webrtc::VideoCodec.codecSpecific

Instead of reaching into an union, we use accessors.

BUG=webrtc:6603
==========

to

==========
Stop using webrtc::VideoCodec.codecSpecific

Instead of reaching into an union, we use accessors.

BUG=webrtc:6603

Committed: https://crrev.com/a8215e602cdd32f863d9ab222486dee44b707065
Cr-Commit-Position: refs/heads/master@{#427948}
==========

[commit-bot: I haz the power, 2016-10-27 05:41:21]

Patchset 1 (id:??) landed as
https://crrev.com/a8215e602cdd32f863d9ab222486dee44b707065
Cr-Commit-Position: refs/heads/master@{#427948}