content/renderer/media/gpu/rtc_video_decoder_unittest.cc - Issue 2449353003: Stop using webrtc::VideoCodec.codecSpecific

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/gpu/rtc_video_decoder_unittest.cc

Issue 2449353003: Stop using webrtc::VideoCodec.codecSpecific (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/gpu/rtc_video_decoder_unittest.cc

diff --git a/content/renderer/media/gpu/rtc_video_decoder_unittest.cc b/content/renderer/media/gpu/rtc_video_decoder_unittest.cc

index 151e8fcb285357374854cc834e384f08a1c02c9f..877d457c8d288c7c48aaeb68eab7619368601a7e 100644

--- a/content/renderer/media/gpu/rtc_video_decoder_unittest.cc

+++ b/content/renderer/media/gpu/rtc_video_decoder_unittest.cc

@@ -182,7 +182,7 @@ TEST_P(RTCVideoDecoderTest, CreateAndInitSucceeds) {

TEST_F(RTCVideoDecoderTest, InitDecodeReturnsErrorOnFeedbackMode) {

CreateDecoder(webrtc::kVideoCodecVP8);

- codec_.codecSpecific.VP8.feedbackModeOn = true;

+ codec_.VP8()->feedbackModeOn = true;

wuchengli 2016/10/26 13:53:50 Why this uses VP8()->feedbackModeOn and rtc_video_

EXPECT_EQ(WEBRTC_VIDEO_CODEC_ERROR, rtc_decoder_->InitDecode(&codec_, 1));

}