|
[crankshaft] Refactor kAllowUndefinedAsNaN to kTruncatingToNumber.
The meaning of the HValue::kAllowUndefinedAsNaN is actually ToNumber
conversion (except for the uses in HBranch and HCompareHoleAndBranch,
which were confusing and useless anyways), so fix the naming to match
that.
Also properly integrate the handling of this flag with the existing
truncation analysis that is run as part of the representation changes
phase (i.e. where we already deal with truncating to int32 and smi).
This is done in preparation of allowing Crankshaft to handle any kind
of Oddball in the ToNumber truncation, instead of just undefined for
truncation ToNumber and undefined or boolean for ToInt32. It also helps
to make Crankshaft somewhat more compatible with the (saner)
implementation in TurboFan.
R=yangguo@chromium.org
BUG= v8:5400
Committed: https://crrev.com/df981a9ff5c875fcd0ed2056b371968d5887a595
Cr-Commit-Position: refs/heads/master@{#40577}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+98 lines, -184 lines) |
Patch |
|
M |
BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/crankshaft/arm/lithium-arm.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/crankshaft/arm/lithium-codegen-arm.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
src/crankshaft/arm64/lithium-arm64.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/crankshaft/arm64/lithium-codegen-arm64.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
src/crankshaft/hydrogen.cc
|
View
|
|
6 chunks |
+4 lines, -8 lines |
0 comments
|
Download
|
|
M |
src/crankshaft/hydrogen-instructions.h
|
View
|
|
15 chunks |
+19 lines, -24 lines |
0 comments
|
Download
|
|
M |
src/crankshaft/hydrogen-instructions.cc
|
View
|
|
6 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
|
D |
src/crankshaft/hydrogen-mark-deoptimize.h
|
View
|
|
1 chunk |
+0 lines, -53 lines |
0 comments
|
Download
|
|
D |
src/crankshaft/hydrogen-mark-deoptimize.cc
|
View
|
|
1 chunk |
+0 lines, -62 lines |
0 comments
|
Download
|
|
M |
src/crankshaft/hydrogen-representation-changes.cc
|
View
|
|
5 chunks |
+48 lines, -12 lines |
0 comments
|
Download
|
|
M |
src/crankshaft/ia32/lithium-codegen-ia32.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
src/crankshaft/ia32/lithium-ia32.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/crankshaft/mips/lithium-codegen-mips.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
src/crankshaft/mips/lithium-mips.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/crankshaft/mips64/lithium-codegen-mips64.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
src/crankshaft/mips64/lithium-mips64.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/crankshaft/x64/lithium-codegen-x64.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
src/crankshaft/x64/lithium-x64.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/v8.gyp
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
Total messages: 11 (6 generated)
|