Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: src/crankshaft/hydrogen.cc

Issue 2449353002: [crankshaft] Refactor kAllowUndefinedAsNaN to kTruncatingToNumber. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/arm64/lithium-codegen-arm64.cc ('k') | src/crankshaft/hydrogen-instructions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen.cc
diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc
index 7182b6586c9f4a17af0bffc7b13373a80a4a4065..16c3639a3d33dbaebaecfa71aeb90bbc11242ff2 100644
--- a/src/crankshaft/hydrogen.cc
+++ b/src/crankshaft/hydrogen.cc
@@ -23,7 +23,6 @@
#include "src/crankshaft/hydrogen-infer-representation.h"
#include "src/crankshaft/hydrogen-infer-types.h"
#include "src/crankshaft/hydrogen-load-elimination.h"
-#include "src/crankshaft/hydrogen-mark-deoptimize.h"
#include "src/crankshaft/hydrogen-mark-unreachable.h"
#include "src/crankshaft/hydrogen-osr.h"
#include "src/crankshaft/hydrogen-range-analysis.h"
@@ -2970,12 +2969,12 @@ void HGraphBuilder::BuildCopyElements(HValue* from_elements,
if_hole.Else();
HStoreKeyed* store =
Add<HStoreKeyed>(to_elements, key, element, nullptr, kind);
- store->SetFlag(HValue::kAllowUndefinedAsNaN);
+ store->SetFlag(HValue::kTruncatingToNumber);
if_hole.End();
} else {
HStoreKeyed* store =
Add<HStoreKeyed>(to_elements, key, element, nullptr, kind);
- store->SetFlag(HValue::kAllowUndefinedAsNaN);
+ store->SetFlag(HValue::kTruncatingToNumber);
}
builder.EndBody();
@@ -4131,7 +4130,6 @@ bool HGraph::Optimize(BailoutReason* bailout_reason) {
// This must happen after inferring representations.
Run<HMergeRemovableSimulatesPhase>();
- Run<HMarkDeoptimizeOnUndefinedPhase>();
Run<HRepresentationChangesPhase>();
Run<HInferTypesPhase>();
@@ -4151,8 +4149,6 @@ bool HGraph::Optimize(BailoutReason* bailout_reason) {
Run<HRangeAnalysisPhase>();
- Run<HComputeChangeUndefinedToNaN>();
-
// Eliminate redundant stack checks on backwards branches.
Run<HStackCheckEliminationPhase>();
@@ -8769,7 +8765,7 @@ bool HOptimizedGraphBuilder::TryInlineBuiltinMethodCall(
copy_kind, ALLOW_RETURN_HOLE);
HStoreKeyed* store = Add<HStoreKeyed>(elements, new_key, element,
nullptr, copy_kind);
- store->SetFlag(HValue::kAllowUndefinedAsNaN);
+ store->SetFlag(HValue::kTruncatingToNumber);
}
loop.EndBody();
@@ -11712,7 +11708,7 @@ void HOptimizedGraphBuilder::BuildEmitFixedDoubleArray(
kind, ALLOW_RETURN_HOLE);
HInstruction* store = Add<HStoreKeyed>(object_elements, key_constant,
value_instruction, nullptr, kind);
- store->SetFlag(HValue::kAllowUndefinedAsNaN);
+ store->SetFlag(HValue::kTruncatingToNumber);
}
}
« no previous file with comments | « src/crankshaft/arm64/lithium-codegen-arm64.cc ('k') | src/crankshaft/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698