Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2449313002: Refactor LayoutCurrentChild (Closed)

Created:
4 years, 1 month ago by atotic
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

I've refactored LayoutCurrentChild for readability, TRACE for "no code in headers" The switch statement that got refactored is going to grow for absrel, this'll make it more manageable. ptal BUG=635619 Committed: https://crrev.com/61cb21c3ff7bf876d947eceee36fd756cd5b8fef Cr-Commit-Position: refs/heads/master@{#427914}

Patch Set 1 #

Patch Set 2 : Refactor LayoutCurrentChild #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -30 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 1 2 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 3 chunks +38 lines, -23 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
atotic
4 years, 1 month ago (2016-10-26 05:19:02 UTC) #3
cbiesinger
lgtm, note merge conflict with https://codereview.chromium.org/2453553002
4 years, 1 month ago (2016-10-26 19:59:55 UTC) #4
atotic
On 2016/10/26 at 19:59:55, cbiesinger wrote: > lgtm, note merge conflict with https://codereview.chromium.org/2453553002 Am I ...
4 years, 1 month ago (2016-10-26 23:34:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449313002/20001
4 years, 1 month ago (2016-10-27 00:46:24 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-27 02:06:32 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 02:09:18 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/61cb21c3ff7bf876d947eceee36fd756cd5b8fef
Cr-Commit-Position: refs/heads/master@{#427914}

Powered by Google App Engine
This is Rietveld 408576698