Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

Issue 2449313002: Refactor LayoutCurrentChild (Closed)
Patch Set: Refactor LayoutCurrentChild Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
index 2a92f89933cf66eba02ed6ac5886661412114489..cb44a4c7c4e5040f8a39dd0e1159950f62420b47 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
@@ -37,13 +37,7 @@ class CORE_EXPORT NGBlockLayoutAlgorithm : public NGLayoutAlgorithm {
// returns true. The same constraint space has to be passed each time.
bool Layout(const NGConstraintSpace*, NGPhysicalFragment**) override;
- DEFINE_INLINE_VIRTUAL_TRACE() {
- NGLayoutAlgorithm::trace(visitor);
- visitor->trace(first_child_);
- visitor->trace(builder_);
- visitor->trace(constraint_space_for_children_);
- visitor->trace(current_child_);
- }
+ DECLARE_VIRTUAL_TRACE();
private:
// Computes collapsed margins for 2 adjoining blocks and updates the resultant
@@ -85,6 +79,8 @@ class CORE_EXPORT NGBlockLayoutAlgorithm : public NGLayoutAlgorithm {
// keeps updating block-end (on every non-zero height child).
void UpdateMarginStrut(const NGMarginStrut& from);
+ bool LayoutCurrentChild(const NGConstraintSpace*);
+
// Read-only Getters.
const ComputedStyle& Style() const { return *style_; }
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698