Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2449303002: W3C test importer: only consider tests to be renamed with 100% similarity. (Closed)

Created:
4 years, 1 month ago by qyearsley
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, foolip, tkent
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

W3C test importer: only consider tests to be renamed with 100% similarity. BUG=649010 Committed: https://crrev.com/15fc403e351f277a622ba802104f60a12c43f3c4 Cr-Commit-Position: refs/heads/master@{#427820}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 2 chunks +2 lines, -2 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
qyearsley
This is a fix for an issue which w3c-test-autoroller is hitting now -- See https://bugs.chromium.org/p/chromium/issues/detail?id=649010#c7
4 years, 1 month ago (2016-10-25 23:01:43 UTC) #2
Dirk Pranke
lgtm https://codereview.chromium.org/2449303002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right): https://codereview.chromium.org/2449303002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py#newcode427 third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:427: out = self.check_run(['git', 'diff', 'origin/master', '-M100%', '--diff-filter=D', '--name-only']) ...
4 years, 1 month ago (2016-10-26 17:50:25 UTC) #3
qyearsley
https://codereview.chromium.org/2449303002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right): https://codereview.chromium.org/2449303002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py#newcode427 third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:427: out = self.check_run(['git', 'diff', 'origin/master', '-M100%', '--diff-filter=D', '--name-only']) On ...
4 years, 1 month ago (2016-10-26 18:00:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449303002/1
4 years, 1 month ago (2016-10-26 18:00:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 21:43:38 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 21:47:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15fc403e351f277a622ba802104f60a12c43f3c4
Cr-Commit-Position: refs/heads/master@{#427820}

Powered by Google App Engine
This is Rietveld 408576698