W3C test importer: only consider tests to be renamed with 100% similarity.

W3C test importer: only consider tests to be renamed with 100% similarity.

BUG=649010
Committed: https://crrev.com/15fc403e351f277a622ba802104f60a12c43f3c4
Cr-Commit-Position: refs/heads/master@{#427820}

[qyearsley, 2016-10-25 23:01:42]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[qyearsley, 2016-10-25 23:01:43]

This is a fix for an issue which w3c-test-autoroller is hitting now --
See https://bugs.chromium.org/p/chromium/issues/detail?id=649010#c7

[Dirk Pranke, 2016-10-26 17:50:25]

lgtm

https://codereview.chromium.org/2449303002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right):

https://codereview.chromium.org/2449303002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:427: out =
self.check_run(['git', 'diff', 'origin/master', '-M100%', '--diff-filter=D',
'--name-only'])
You might want --no-rename instead, I'm not sure if there'll be much of a
difference.

[qyearsley, 2016-10-26 18:00:19]

https://codereview.chromium.org/2449303002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right):

https://codereview.chromium.org/2449303002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:427: out =
self.check_run(['git', 'diff', 'origin/master', '-M100%', '--diff-filter=D',
'--name-only'])
On 2016/10/26 at 17:50:25, Dirk Pranke (slow) wrote:
> You might want --no-rename instead, I'm not sure if there'll be much of a
difference.

It looks like the difference is: with --no-renames, even renames with 100%
similarity are considered a delete and add instead of a rename. With -M100%,
simple renames with no change in content are still considered renames, and not
deletions/additions.

Potentially, I could change this to only remove deleted/renamed files from
TestExpectation, and not update them when they're renamed them, and that would
be a little simpler. But, I think it would still be good to keep the behavior of
updating instead of removing expectation lines when there's just a simple rename
with no change in test content.

[qyearsley, 2016-10-26 18:00:22]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-10-26 18:00:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 21:43:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-26 21:47:35]

Description was changed from

==========
W3C test importer: only consider tests to be renamed with 100% similarity.

BUG=649010
==========

to

==========
W3C test importer: only consider tests to be renamed with 100% similarity.

BUG=649010

Committed: https://crrev.com/15fc403e351f277a622ba802104f60a12c43f3c4
Cr-Commit-Position: refs/heads/master@{#427820}
==========

[commit-bot: I haz the power, 2016-10-26 21:47:36]

Patchset 1 (id:??) landed as
https://crrev.com/15fc403e351f277a622ba802104f60a12c43f3c4
Cr-Commit-Position: refs/heads/master@{#427820}