Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

Issue 2449303002: W3C test importer: only consider tests to be renamed with 100% similarity. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
index 9726fa200c9c79c53be871e5a27ac52b9662bb1a..4f16805503bd56a142791262a4ed9ab2077a4985 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
@@ -424,7 +424,7 @@ class DepsUpdater(object):
def _list_deleted_tests(self):
"""Returns a list of layout tests that have been deleted."""
- out = self.check_run(['git', 'diff', 'origin/master', '--diff-filter=D', '--name-only'])
+ out = self.check_run(['git', 'diff', 'origin/master', '-M100%', '--diff-filter=D', '--name-only'])
Dirk Pranke 2016/10/26 17:50:25 You might want --no-rename instead, I'm not sure i
qyearsley 2016/10/26 18:00:19 It looks like the difference is: with --no-renames
deleted_tests = []
for line in out.splitlines():
test = self.finder.layout_test_name(line)
@@ -434,7 +434,7 @@ class DepsUpdater(object):
def _list_renamed_tests(self):
"""Returns a dict mapping source to dest name for layout tests that have been renamed."""
- out = self.check_run(['git', 'diff', 'origin/master', '--diff-filter=R', '--name-status'])
+ out = self.check_run(['git', 'diff', 'origin/master', '-M100%', '--diff-filter=R', '--name-status'])
renamed_tests = {}
for line in out.splitlines():
_, source_path, dest_path = line.split()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698