Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: src/debug/debug-interface.h

Issue 2449213002: [inspector] migrate scriptParsed and getCompiledScripts to native (Closed)
Patch Set: addressed comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/debug/debug-interface.h
diff --git a/src/debug/debug-interface.h b/src/debug/debug-interface.h
index 0577ecc4ca2b5980aaa979da0e74831b9a2bea47..ff980e4065ef8090740f9dd5da786306207340af 100644
--- a/src/debug/debug-interface.h
+++ b/src/debug/debug-interface.h
@@ -6,6 +6,7 @@
#define V8_DEBUG_DEBUG_INTERFACE_H_
#include "include/v8-debug.h"
+#include "include/v8-util.h"
#include "include/v8.h"
namespace v8 {
@@ -138,6 +139,27 @@ class DebugInterface {
static void PrepareStep(Isolate* isolate, StepAction action);
static void ClearStepping(Isolate* isolate);
+
+ class Script {
dgozman 2016/10/28 19:57:15 What about comments? Do we drop the altogether or
kozy 2016/10/28 20:59:37 Done.
+ public:
+ ScriptOriginOptions OriginOptions() const;
+ bool WasCompiled() const;
+ int Id() const;
+ int LineOffset() const;
+ int ColumnOffset() const;
+ MaybeLocal<Array> LineEnds(v8::Local<v8::Context>) const;
dgozman 2016/10/28 19:57:15 Let's go with vector<int>, and remove all contexts
kozy 2016/10/28 20:59:37 Done.
+ MaybeLocal<String> Name(v8::Local<v8::Context>) const;
+ MaybeLocal<String> SourceURL(v8::Local<v8::Context>) const;
+ MaybeLocal<String> SourceMappingURL(v8::Local<v8::Context>) const;
+ MaybeLocal<String> ContextData(v8::Local<v8::Context>) const;
+ MaybeLocal<String> Source(v8::Local<v8::Context>) const;
+
+ static MaybeLocal<Script> Wrap(v8::Local<v8::Context>,
dgozman 2016/10/28 19:57:15 We definitely need a comment for this one.
kozy 2016/10/28 20:59:37 Done.
+ v8::Local<v8::Object>);
+ };
+
+ static void GetLoadedScripts(Isolate* isolate,
+ PersistentValueVector<Script>& scripts);
};
} // namespace v8

Powered by Google App Engine
This is Rietveld 408576698