Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Side by Side Diff: src/debug/debug-interface.h

Issue 2449213002: [inspector] migrate scriptParsed and getCompiledScripts to native (Closed)
Patch Set: addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_DEBUG_DEBUG_INTERFACE_H_ 5 #ifndef V8_DEBUG_DEBUG_INTERFACE_H_
6 #define V8_DEBUG_DEBUG_INTERFACE_H_ 6 #define V8_DEBUG_DEBUG_INTERFACE_H_
7 7
8 #include "include/v8-debug.h" 8 #include "include/v8-debug.h"
9 #include "include/v8-util.h"
9 #include "include/v8.h" 10 #include "include/v8.h"
10 11
11 namespace v8 { 12 namespace v8 {
12 13
13 class DebugInterface { 14 class DebugInterface {
14 public: 15 public:
15 /** 16 /**
16 * An event details object passed to the debug event listener. 17 * An event details object passed to the debug event listener.
17 */ 18 */
18 class EventDetails : public v8::Debug::EventDetails { 19 class EventDetails : public v8::Debug::EventDetails {
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 enum StepAction { 132 enum StepAction {
132 StepOut = 0, // Step out of the current function. 133 StepOut = 0, // Step out of the current function.
133 StepNext = 1, // Step to the next statement in the current function. 134 StepNext = 1, // Step to the next statement in the current function.
134 StepIn = 2, // Step into new functions invoked or the next statement 135 StepIn = 2, // Step into new functions invoked or the next statement
135 // in the current function. 136 // in the current function.
136 StepFrame = 3 // Step into a new frame or return to previous frame. 137 StepFrame = 3 // Step into a new frame or return to previous frame.
137 }; 138 };
138 139
139 static void PrepareStep(Isolate* isolate, StepAction action); 140 static void PrepareStep(Isolate* isolate, StepAction action);
140 static void ClearStepping(Isolate* isolate); 141 static void ClearStepping(Isolate* isolate);
142
143 class Script {
dgozman 2016/10/28 19:57:15 What about comments? Do we drop the altogether or
kozy 2016/10/28 20:59:37 Done.
144 public:
145 ScriptOriginOptions OriginOptions() const;
146 bool WasCompiled() const;
147 int Id() const;
148 int LineOffset() const;
149 int ColumnOffset() const;
150 MaybeLocal<Array> LineEnds(v8::Local<v8::Context>) const;
dgozman 2016/10/28 19:57:15 Let's go with vector<int>, and remove all contexts
kozy 2016/10/28 20:59:37 Done.
151 MaybeLocal<String> Name(v8::Local<v8::Context>) const;
152 MaybeLocal<String> SourceURL(v8::Local<v8::Context>) const;
153 MaybeLocal<String> SourceMappingURL(v8::Local<v8::Context>) const;
154 MaybeLocal<String> ContextData(v8::Local<v8::Context>) const;
155 MaybeLocal<String> Source(v8::Local<v8::Context>) const;
156
157 static MaybeLocal<Script> Wrap(v8::Local<v8::Context>,
dgozman 2016/10/28 19:57:15 We definitely need a comment for this one.
kozy 2016/10/28 20:59:37 Done.
158 v8::Local<v8::Object>);
159 };
160
161 static void GetLoadedScripts(Isolate* isolate,
162 PersistentValueVector<Script>& scripts);
141 }; 163 };
142 164
143 } // namespace v8 165 } // namespace v8
144 166
145 #endif // V8_DEBUG_DEBUG_INTERFACE_H_ 167 #endif // V8_DEBUG_DEBUG_INTERFACE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698