Allow immutable prototype templates to inherit

Allow immutable prototype templates to inherit

To enable the global object prototype chain to be frozen, all objects
in the chain need to be marked as immutable prototype exotic objects.
However, a bug in the previous implementation of immutable prototype
exotic objects left the check in place when initially setting up the
object, which made it impossible to allow inheritance chains. This
patch removes that mistaken check.

BUG=v8:5149
Committed: https://crrev.com/baf0ec31ec8c16156f3808cc31fd980ac05b109a
Cr-Commit-Position: refs/heads/master@{#40702}

[Dan Ehrenberg, 2016-10-26 19:45:48]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 19:45:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2016-10-26 19:45:53]

littledan@chromium.org changed reviewers:
+ adamk@chromium.org

[commit-bot: I haz the power, 2016-10-26 19:49:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 19:49:43]

Dry run: Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/27390)

[Dan Ehrenberg, 2016-10-26 19:53:52]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 19:54:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 20:21:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 20:21:02]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-10-26 20:23:33]

Is it valid to skip the checks this way? I don't see any that should fail from
an ObjectTemplate.

[adamk, 2016-10-27 08:06:07]

adamk@chromium.org changed reviewers:
+ verwaest@chromium.org

[adamk, 2016-10-27 08:06:07]

Anything that says "ForceSet" makes my spine tingle a little. Adding verwaest@,
lord of all things ForceSet.

[Toon Verwaest, 2016-10-28 14:07:37]

This is exactly the right thing to do: manual setup from api/bootstrapper
shouldn't be doing the "JS thing".

[Toon Verwaest, 2016-10-28 14:07:46]

lgtm

[Dan Ehrenberg, 2016-11-02 13:33:23]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-11-02 13:33:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 13:59:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:19:29]

Description was changed from

==========
Allow immutable prototype templates to inherit

To enable the global object prototype chain to be frozen, all objects
in the chain need to be marked as immutable prototype exotic objects.
However, a bug in the previous implementation of immutable prototype
exotic objects left the check in place when initially setting up the
object, which made it impossible to allow inheritance chains. This
patch removes that mistaken check.

BUG=v8:5149
==========

to

==========
Allow immutable prototype templates to inherit

To enable the global object prototype chain to be frozen, all objects
in the chain need to be marked as immutable prototype exotic objects.
However, a bug in the previous implementation of immutable prototype
exotic objects left the check in place when initially setting up the
object, which made it impossible to allow inheritance chains. This
patch removes that mistaken check.

BUG=v8:5149

Committed: https://crrev.com/baf0ec31ec8c16156f3808cc31fd980ac05b109a
Cr-Commit-Position: refs/heads/master@{#40702}
==========

[commit-bot: I haz the power, 2016-11-17 22:19:30]

Patchset 2 (id:??) landed as
https://crrev.com/baf0ec31ec8c16156f3808cc31fd980ac05b109a
Cr-Commit-Position: refs/heads/master@{#40702}