Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: src/api-natives.cc

Issue 2449163004: Allow immutable prototype templates to inherit (Closed)
Patch Set: Fix up test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api-natives.cc
diff --git a/src/api-natives.cc b/src/api-natives.cc
index a620b210a4b65156560b3788d3fa3ce8322d3ccb..ab1b06256e0301b0ba60ef4705a203ed9a3476b5 100644
--- a/src/api-natives.cc
+++ b/src/api-natives.cc
@@ -437,9 +437,7 @@ MaybeHandle<JSFunction> InstantiateFunction(Isolate* isolate,
JSObject::GetProperty(parent_instance,
isolate->factory()->prototype_string()),
JSFunction);
- MAYBE_RETURN(JSObject::SetPrototype(prototype, parent_prototype, false,
- Object::THROW_ON_ERROR),
- MaybeHandle<JSFunction>());
+ JSObject::ForceSetPrototype(prototype, parent_prototype);
}
}
Handle<JSFunction> function = ApiNatives::CreateApiFunction(
« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698