Chromium Code Reviews
DescriptionExplicitly skip notification announcements in SpokenFeedbackTest
Since ChromeVox Next behaves slightly differently (it is more aggressive about placing initial focus), there are a lot more utterances that can occur on startup. In addition, it triggers a notification center alert which also causes output.
This cl skips those messages explicitly.
Also, disable
TypeInOmniBox
because on slower debug builds, it appears we're actually prepending when typing to about:blank.
NavigateNotificationCenter
This test is super brittle because it relies on the "Button" utterance to trigger tabbing.
In general, most of these tests are brittle because they rely upon a strict ordering of utterances with no tolerance for various UI events. This should be solved later hopefully with the js-based tests in chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs as an example.
BUG=659181
TBR=dmazzoni@chromium.org
Committed: https://crrev.com/f66eb9d5822ec392f9b7262cf3662924e80b0b93
Cr-Commit-Position: refs/heads/master@{#427444}
Patch Set 1 #
Messages
Total messages: 7 (4 generated)
|
||||||||||||||||||||||||||||