Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2449043004: Explicitly skip notification announcements in SpokenFeedbackTest (Closed)

Created:
4 years, 1 month ago by David Tseng
Modified:
4 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly skip notification announcements in SpokenFeedbackTest Since ChromeVox Next behaves slightly differently (it is more aggressive about placing initial focus), there are a lot more utterances that can occur on startup. In addition, it triggers a notification center alert which also causes output. This cl skips those messages explicitly. Also, disable TypeInOmniBox because on slower debug builds, it appears we're actually prepending when typing to about:blank. NavigateNotificationCenter This test is super brittle because it relies on the "Button" utterance to trigger tabbing. In general, most of these tests are brittle because they rely upon a strict ordering of utterances with no tolerance for various UI events. This should be solved later hopefully with the js-based tests in chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs as an example. BUG=659181 TBR=dmazzoni@chromium.org Committed: https://crrev.com/f66eb9d5822ec392f9b7262cf3662924e80b0b93 Cr-Commit-Position: refs/heads/master@{#427444}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M chrome/browser/chromeos/accessibility/speech_monitor.cc View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 4 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449043004/1
4 years, 1 month ago (2016-10-25 19:15:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 19:45:31 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 20:00:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f66eb9d5822ec392f9b7262cf3662924e80b0b93
Cr-Commit-Position: refs/heads/master@{#427444}

Powered by Google App Engine
This is Rietveld 408576698