Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc

Issue 2449043004: Explicitly skip notification announcements in SpokenFeedbackTest (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/accessibility/speech_monitor.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
diff --git a/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc b/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
index a3aaf04e4eb82fd6022c221f0c989e74c698d549..e3a1b70da126ddb93afbb3db5c18c9ccb68291cc 100644
--- a/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
+++ b/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
@@ -132,12 +132,6 @@ class LoggedInSpokenFeedbackTest : public InProcessBrowserTest {
true, ash::A11Y_NOTIFICATION_NONE);
EXPECT_TRUE(speech_monitor_.SkipChromeVoxEnabledMessage());
DisableEarcons();
-
- // Ensure we skip all other startup messages by sending an additional speak
- // call.
- RunJavaScriptInChromeVoxBackgroundPage(
- "cvox.ChromeVox.tts.speak('ready to test');");
- EXPECT_TRUE(speech_monitor_.SkipChromeVoxMessage("ready to test"));
}
void PressRepeatedlyUntilUtterance(ui::KeyboardCode key,
@@ -210,7 +204,8 @@ IN_PROC_BROWSER_TEST_F(LoggedInSpokenFeedbackTest, DISABLED_AddBookmark) {
EXPECT_EQ("button", speech_monitor_.GetNextUtterance());
}
-IN_PROC_BROWSER_TEST_F(LoggedInSpokenFeedbackTest, NavigateNotificationCenter) {
+IN_PROC_BROWSER_TEST_F(LoggedInSpokenFeedbackTest,
+ DISABLED_NavigateNotificationCenter) {
EnableChromeVox();
EXPECT_TRUE(PerformAcceleratorAction(ash::SHOW_MESSAGE_CENTER_BUBBLE));
@@ -293,7 +288,7 @@ IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, FocusToolbar) {
EXPECT_EQ("Button", speech_monitor_.GetNextUtterance());
}
-IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, TypeInOmnibox) {
+IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, DISABLED_TypeInOmnibox) {
EnableChromeVox();
// Location bar has focus by default so just start typing.
@@ -495,7 +490,7 @@ IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, OverviewMode) {
if (base::MatchPattern(utterance, "Edit text"))
break;
}
- EXPECT_EQ("Alert", speech_monitor_.GetNextUtterance());
+
EXPECT_EQ("Entered window overview mode", speech_monitor_.GetNextUtterance());
SendKeyPress(ui::VKEY_TAB);
« no previous file with comments | « chrome/browser/chromeos/accessibility/speech_monitor.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698